Kubernetes Dashboard v1.7.1 Refactor #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
ci check this |
chadswen
force-pushed
the
dashboard-refactor
branch
from
8c8271b to
e25e7b4
Compare
|
Looks like CI is malfunctioning :/ |
|
CI is unstuck now, and it passed. |
Atoms
reviewed
Nov 13, 2017
| kubectl: "{{bin_dir}}/kubectl" | ||
| resource: "{{ item }}" | ||
| state: absent | ||
| with_items: ['ClusterRoleBinding'] |
There was a problem hiding this comment.
this is not critical, but can you please write all lists more readable like:
with_items:
- ClusterRoleBinding
this way it's more readable when overlooking code, and more easy to add/remove more items if needed anywhere.
There was a problem hiding this comment.
I agree that's better, it's usually my preferred syntax. I was just sticking with the convention I saw used elsewhere in this role for dns cleanup.
There was a problem hiding this comment.
we are trying to change this in long term
Atoms
approved these changes
Nov 13, 2017
|
Added ability to use custom cert secret and addressed |
chadswen
force-pushed
the
dashboard-refactor
branch
from
0189978 to
ac9e57f
Compare
This version required changing the previous access model for dashboard completely but it's a change for the better. Docs were updated. * New login/auth options that use apiserver auth proxying by default * Requires RBAC in `authorization_modes` * Only serves over https * No longer available at https://first_master:6443/ui until apiserver is updated with the https proxy URL: * Can access from https://first_master:6443/api/v1/namespaces/kube-system/services/https:kubernetes-dashboard:/proxy/#!/login you will be prompted for credentials * Or you can run 'kubectl proxy' from your local machine to access dashboard in your browser from: http://localhost:8001/api/v1/namespaces/kube-system/services/https:kubernetes-dashboard:/proxy/ * It is recommended to access dashboard from behind a gateway that enforces an authentication token, details and other access options here: https://github.com/kubernetes/dashboard/wiki/Accessing-Dashboard---1.7.X-and-above
…sioned self-signed certs
chadswen
force-pushed
the
dashboard-refactor
branch
from
ac9e57f to
a89ee8c
Compare
|
Rebased |
bradbeam
approved these changes
Nov 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version required changing the previous access model for dashboard completely but it's a change for the better. Docs were updated.
authorization_modesCloses #1851 Closes #1896