-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update multus to v4.1.0 and clarify cilium compatibility #11434
Conversation
Hi @ThisIsQasim. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
HI @ThisIsQasim It's better to squash the commit. |
Hi @yankay, sure I have squashed the commits |
Wondering if I should add tests for multus with cilium? |
You can try to see if this is easy to add, or you can manually test it. |
I have a cluster with cilium where I manually tested this but I can try adding automated tests. |
… break if multus was defined
So seems like #10934 introduced a bug where if
Should I create a separate issue for that and reference it here? I have also added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I create a separate issue for that and reference it here?
That would be great! thanks for your fix. It Looks good!
/lgtm
/cc @yankay
Thanks @ThisIsQasim |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyclinder, ThisIsQasim, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…sigs#11434) * Update multus to v4.1.0 and clarify cilium compatibility * Fix: bug introduced by kubernetes-sigs#10934 where the template would break if multus was defined * Set priorityClassName to system-node-critical for multus pods
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Updates multus version to
v4.1.0
and updates docs to clarify cilium configSpecial notes for your reviewer:
Does this PR introduce a user-facing change?: