Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multus to v4.1.0 and clarify cilium compatibility #11434

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

ThisIsQasim
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Updates multus version to v4.1.0 and updates docs to clarify cilium config

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update multus to v4.1.0

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 9, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ThisIsQasim. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2024
@yankay
Copy link
Member

yankay commented Aug 14, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2024
@yankay
Copy link
Member

yankay commented Aug 14, 2024

HI @ThisIsQasim

It's better to squash the commit.

@ThisIsQasim ThisIsQasim changed the title Update multus to v4.1.0 and clarify cilium config Update multus to v4.1.0 and clarify cilium compatibility Aug 14, 2024
@ThisIsQasim
Copy link
Contributor Author

Hi @yankay, sure I have squashed the commits

@yankay yankay requested a review from cyclinder August 14, 2024 09:04
@ThisIsQasim
Copy link
Contributor Author

Wondering if I should add tests for multus with cilium?

@cyclinder
Copy link
Contributor

Wondering if I should add tests for multus with cilium?

You can try to see if this is easy to add, or you can manually test it.

@ThisIsQasim
Copy link
Contributor Author

Wondering if I should add tests for multus with cilium?

You can try to see if this is easy to add, or you can manually test it.

I have a cluster with cilium where I manually tested this but I can try adding automated tests.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2024
@k8s-ci-robot k8s-ci-robot requested a review from yankay August 19, 2024 02:00
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/contains-merge-commits and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 30, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2024
@ThisIsQasim
Copy link
Contributor Author

ThisIsQasim commented Sep 6, 2024

So seems like #10934 introduced a bug where if multus was enabled the template would throw an error about multus_manifest_2.results attribute not existing. I have added a fix for that as well.

fatal: [node1]: FAILED! => {"msg": "'ansible.vars.hostvars.HostVarsVars object' has no attribute 'multus_manifest_2.results'. 'ansible.vars.hostvars.HostVarsVars object' has no attribute 'multus_manifest_2.results'"}

Should I create a separate issue for that and reference it here?

I have also added a priorityclass for the pods as mentioned in #11304
cc: @yankay @cyclinder

Copy link
Contributor

@cyclinder cyclinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I create a separate issue for that and reference it here?

That would be great! thanks for your fix. It Looks good!

/lgtm
/cc @yankay

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2024
@yankay
Copy link
Member

yankay commented Sep 9, 2024

Thanks @ThisIsQasim
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyclinder, ThisIsQasim, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 538a1f2 into kubernetes-sigs:master Sep 9, 2024
40 checks passed
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
…sigs#11434)

* Update multus to v4.1.0 and clarify cilium compatibility

* Fix: bug introduced by kubernetes-sigs#10934 where the template would break if multus was defined

* Set priorityClassName to system-node-critical for multus pods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants