Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to configure dependencies for kubelet.service #11297

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Added option to configure dependencies for kubelet.service #11297

merged 1 commit into from
Jun 26, 2024

Conversation

ledroide
Copy link
Contributor

@ledroide ledroide commented Jun 14, 2024 •
edited
Loading

What type of PR is this?:

/kind feature

What this PR does / why we need it:

It helps to solve issues related to kubelet systemd service dependencies, such as nfs and rpc-statd issues.

Special notes for your reviewer:

Tested :

  • add kubelet_systemd_wants_dependencies: ["rpc-statd.service"] in inventory file group_vars/k8s_cluster/k8s-cluster.yaml
  • apply full cluster.yml playbook
  • on servers, the line Wants=rpc-statd.service is correctly added to [Unit] section
  • systemctl stop rpc-statd
  • systemctl restart kubelet
  • systemctl status rpc-statd
  • result OK : rpc-statd is started

Does this PR introduce a user-facing change?:

New variable documented in docs/variables.md. As long as this variable is not set, nothing changes.

Added option to configure dependencies for kubelet.service

@ledroide
dependencies for kubelet.service
158af1e 
Signed-off-by: serge Hartmann <serge.hartmann@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ledroide. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from ErikJiang and mzaian June 14, 2024 13:14
@ledroide ledroide changed the title Option to configure dependencies for kubelet.service Added option to configure dependencies for kubelet.service Jun 14, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 14, 2024
@yankay
Copy link
Member

yankay commented Jun 18, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2024
@yankay
Copy link
Member

yankay commented Jun 21, 2024

Thanks @ledroide
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ledroide, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2024
@ant31
Copy link
Contributor

ant31 commented Jun 26, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit db316a5 into kubernetes-sigs:master Jun 26, 2024
79 checks passed
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
@ledroide @Rickkwa
dependencies for kubelet.service (kubernetes-sigs#11297)
4348801 
Signed-off-by: serge Hartmann <serge.hartmann@gmail.com>
@yankay yankay mentioned this pull request Aug 28, 2024
Closed
davidumea pushed a commit to elastisys/kubespray that referenced this pull request Oct 25, 2024
@ledroide @davidumea
dependencies for kubelet.service (kubernetes-sigs#11297)
002990d 
Signed-off-by: serge Hartmann <serge.hartmann@gmail.com>
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
@ledroide @kpoxo6op
dependencies for kubelet.service (kubernetes-sigs#11297)
418cdfd 
Signed-off-by: serge Hartmann <serge.hartmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

@mzaian mzaian Awaiting requested review from mzaian

Assignees

@ant31 ant31

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ledroide @k8s-ci-robot @yankay @ant31