Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added variables cilium_enable_host_firewall and cilium_policy_audit_mode for configmap/cilium-config #11230

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Added variables cilium_enable_host_firewall and cilium_policy_audit_mode for configmap/cilium-config #11230

merged 1 commit into from
Sep 30, 2024

Conversation

ledroide
Copy link
Contributor

@ledroide ledroide commented May 23, 2024 •
edited
Loading

What type of PR is this?

/kind feature

Special notes for your reviewer:

In order to enable (Cilium Host Firewall](https://docs.cilium.io/en/latest/security/host-firewall/) and the recommended PolicyAuditMode that prevents unwanted side effects during testing, we have added 2 variables to cilium role and to inventory (features are disabled by default) :

cilium_enable_host_firewall: false
cilium_policy_audit_mode: false

These features are then added in ConfigMap/cilium-config by cilium role - here set to "true" for the demo. Quotes and capitalized values in this configmap are required.

enable-host-firewall: "True"
policy-audit-mode: "False"

We have added related documentation in docs/cilium.md

Does this PR introduce a user-facing change?:

No facing change. Default settings are set to "false", so there is no difference to cilium behavior when keeping default values.

Add optional support for _Host Firewall_ and _PolicyAuditMode_ features in Cilium

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 23, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ledroide. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ledroide
Copy link
Contributor Author

The pipeline failed a week ago with error messages that do not have any relation with the changes of this PR.

How can I force these checks to run again ?

@ledroide ledroide force-pushed the ciliumhostfirewall branch from d6b4c64 to 149f203 Compare June 14, 2024 06:30
@ledroide ledroide changed the title variables cilium_enable_host_firewall and cilium_policy_audit_mode for configmap/cilium-config Added variables cilium_enable_host_firewall and cilium_policy_audit_mode for configmap/cilium-config Jun 14, 2024
@ledroide ledroide force-pushed the ciliumhostfirewall branch from cd17445 to 7edb4a4 Compare June 21, 2024 06:35
@ledroide
Copy link
Contributor Author

ledroide commented Jun 21, 2024 •
edited
Loading

Hello dear reviewers Arthur and Erik @MrFreezeex @ErikJiang.

Since I have pushed this PR a month ago, the check does not pass a test stage with error ci-not-authorized. It looks like I can't do anything about this error.

I had already tried the same changes in March, ref #10989 , and tried solve it by cancelling the first PR and open this one - unfortunately with no more success.

May you please test and approve this PR ?

@yankay
Copy link
Member

yankay commented Jun 21, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 21, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 19, 2024
@ledroide
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 19, 2024
@ledroide
Copy link
Contributor Author

Is it still ok to test ? When this test is it planned ?

@VannTen
Copy link
Contributor

VannTen commented Sep 28, 2024

/approve

Can you squash your commits ? The last two fixes the first, so they should be one
(ok-to-test is merely to allow CI to run)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ledroide, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2024
@ledroide
variables cilium_enable_host_firewall and cilium_policy_audit_mode fo…
a340d24 
…r configmap/cilium-config

capitalise values for Host Firewall and Policy Audit Mode
fix missing quotes
@VannTen
Copy link
Contributor

VannTen commented Sep 30, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0eeac59 into kubernetes-sigs:master Sep 30, 2024
39 checks passed
@tico88612
Copy link
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 27, 2024
@tico88612 tico88612 mentioned this pull request Nov 27, 2024
Open
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
@ledroide @kpoxo6op
variables cilium_enable_host_firewall and cilium_policy_audit_mode fo…
d02fffc 
…r configmap/cilium-config (kubernetes-sigs#11230)

capitalise values for Host Firewall and Policy Audit Mode
fix missing quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

@MrFreezeex MrFreezeex Awaiting requested review from MrFreezeex

Assignees

@VannTen VannTen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ledroide @k8s-ci-robot @yankay @k8s-triage-robot @VannTen @tico88612