fix: skip multus when not defined #10934

darkobas2 · 2024-02-17T08:32:29Z

/kind bug

when multus is not installed/defined cluster playbook run would fail:

TASK [kubernetes-apps/network_plugin/multus : Multus | Start resources] 
fatal: [host -> {{ groups['kube_control_plane'][0] }}]: FAILED! => 
{"msg": "Error in jmespath.search in json_query filter plugin:
'ansible.vars.hostvars.HostVarsVars object' has no attribute 'multus_manifest_2'"}

Fix: skip multus when not defined

The default=[] part ensures that if multus_manifest_2 is not defined or doesn't have the 'results' attribute, it defaults to an empty list ([]).
This prevents potential errors that might occur if trying to access attributes on an undefined variable.

fix task failure: TASK [kubernetes-apps/network_plugin/multus : Multus | Start resources] ************************************************ fatal: [hfal12k8n1 -> {{ groups['kube_control_plane'][0] }}]: FAILED! => {"msg": "Error in jmespath.search in json_query filter plugin:\n'ansible.vars.hostvars.HostVarsVars object' has no attribute 'multus_manifest_2'"}

k8s-ci-robot · 2024-02-17T08:32:38Z

Hi @darkobas2. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yankay · 2024-02-18T03:12:38Z

/ok-to-test

mzaian

Hello @darkobas2

Thanks for your PR, could you please write a proper description to the PR. maybe use the default template.

darkobas2 · 2024-02-25T21:55:52Z

Hello @darkobas2

Thanks for your PR, could you please write a proper description to the PR. maybe use the default template.

Hi,
I have updated commit description. is it OK now ?

blackliner · 2024-03-10T20:43:43Z

What is the workaround? I can't run kubespray anymore with v2.24.1

nicolas-goudry · 2024-03-18T12:04:24Z

What is the workaround? I can't run kubespray anymore with v2.24.1

You could patch your local kubespray installation with this diff and command:

diff --git a/roles/kubernetes-apps/network_plugin/multus/tasks/main.yml b/roles/kubernetes-apps/network_plugin/multus/tasks/main.yml
index fdbede55a..54dd1ed61 100644
--- a/roles/kubernetes-apps/network_plugin/multus/tasks/main.yml
+++ b/roles/kubernetes-apps/network_plugin/multus/tasks/main.yml
@@ -9,7 +9,7 @@
     state: "latest"
   delegate_to: "{{ groups['kube_control_plane'][0] }}"
   run_once: true
-  with_items: "{{ multus_manifest_1.results + (multus_nodes_list | map('extract', hostvars, 'multus_manifest_2') | list | json_query('[].results')) }}"
+  with_items: "{{ (multus_manifest_1.results | default([])) + (multus_nodes_list | map('extract', hostvars, 'multus_manifest_2.results') | default([]) | list) }}"
   loop_control:
     label: "{{ item.item.name if item != None else 'skipped' }}"
   vars:

patch --strip 1 --forward --merge --directory "<local-kubespray-directory>" \
    --input "<path-to-patch-file>"

I’m currently using this patch in my kubespray installations and I can confirm everything is working fine now.

IMO this is needed and should be released as soon as possible since it’s failing installations with 2.24.x.

bakito · 2024-05-22T15:23:48Z

Is there any update on this? v2.25.0 is already out with this still not fixed.

relip · 2024-07-01T03:34:14Z

I'm also getting not item is skipped' failed. The error was: The 'skipped' test expects a dictionary error when limiting the nodes and I need to patch the fix every time I need to update my cluster. I hope this PR's going to be merged soon... @mzaian

cyclinder

Thanks for the fix!

/lgtm

/cc @yankay Could you approvel these changes? thanks!

ant31 · 2024-08-06T10:36:28Z

/approve

k8s-ci-robot · 2024-08-06T10:36:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ant31, cyclinder, darkobas2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ant31]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… break if multus was defined

* Update multus to v4.1.0 and clarify cilium compatibility * Fix: bug introduced by #10934 where the template would break if multus was defined * Set priorityClassName to system-node-critical for multus pods

fix task failure: TASK [kubernetes-apps/network_plugin/multus : Multus | Start resources] ************************************************ fatal: [hfal12k8n1 -> {{ groups['kube_control_plane'][0] }}]: FAILED! => {"msg": "Error in jmespath.search in json_query filter plugin:\n'ansible.vars.hostvars.HostVarsVars object' has no attribute 'multus_manifest_2'"}

…sigs#11434) * Update multus to v4.1.0 and clarify cilium compatibility * Fix: bug introduced by kubernetes-sigs#10934 where the template would break if multus was defined * Set priorityClassName to system-node-critical for multus pods

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 17, 2024

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2024

k8s-ci-robot requested review from MrFreezeex and mzaian February 17, 2024 08:32

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2024

yankay assigned cyclinder Feb 18, 2024

mzaian reviewed Feb 19, 2024

View reviewed changes

darkobas2 mentioned this pull request Mar 6, 2024

fix(multus): hostvars has no attribute 'multus_manifest_2' #10974

Closed

cyclinder approved these changes Jul 1, 2024

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024

k8s-ci-robot merged commit 1968db9 into kubernetes-sigs:master Aug 6, 2024
65 checks passed

yankay mentioned this pull request Aug 28, 2024

Release Proposal v2.26 #11447

Closed

ThisIsQasim added a commit to ThisIsQasim/kubespray that referenced this pull request Sep 6, 2024

Fix: bug introduced by kubernetes-sigs#10934 where the template would…

3036d7e

… break if multus was defined

ThisIsQasim mentioned this pull request Sep 6, 2024

Update multus to v4.1.0 and clarify cilium compatibility #11434

Merged

bvujnovac mentioned this pull request Dec 12, 2024

when multus is used cluster playbook run fails on v2.26 #11794

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: skip multus when not defined #10934

fix: skip multus when not defined #10934

darkobas2 commented Feb 17, 2024 •

edited

Loading

k8s-ci-robot commented Feb 17, 2024

yankay commented Feb 18, 2024

mzaian left a comment

darkobas2 commented Feb 25, 2024

blackliner commented Mar 10, 2024

nicolas-goudry commented Mar 18, 2024 •

edited

Loading

bakito commented May 22, 2024

relip commented Jul 1, 2024

cyclinder left a comment

ant31 commented Aug 6, 2024

k8s-ci-robot commented Aug 6, 2024

fix: skip multus when not defined #10934

fix: skip multus when not defined #10934

Conversation

darkobas2 commented Feb 17, 2024 • edited Loading

k8s-ci-robot commented Feb 17, 2024

yankay commented Feb 18, 2024

mzaian left a comment

Choose a reason for hiding this comment

darkobas2 commented Feb 25, 2024

blackliner commented Mar 10, 2024

nicolas-goudry commented Mar 18, 2024 • edited Loading

bakito commented May 22, 2024

relip commented Jul 1, 2024

cyclinder left a comment

Choose a reason for hiding this comment

ant31 commented Aug 6, 2024

k8s-ci-robot commented Aug 6, 2024

darkobas2 commented Feb 17, 2024 •

edited

Loading

nicolas-goudry commented Mar 18, 2024 •

edited

Loading