Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/ingress-nginx service if hostNetwork set to false #10925

Merged
merged 1 commit into from
Feb 19, 2024
Merged

feat/ingress-nginx service if hostNetwork set to false #10925

merged 1 commit into from
Feb 19, 2024

Conversation

chrxmvtik
Copy link
Contributor

@chrxmvtik chrxmvtik commented Feb 15, 2024 •
edited by floryut
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

As of now, if ingress-nginx addon is enabled and has set "ingress_nginx_host_network" to false, then controller will deploy without any service and simply controller will not 'be ingressing' properly, because there is no endpoint where clients can connect.

I've added a template of service kind and modified ansible templates and defaults.

So if "ingress_nginx_host_network" property will be set to false (it is by default), then service with a default type of LoadBalancer will be created.

We can change the default type of the service to anything with "ingress_nginx_service_type" property in addons.

Does this PR introduce a user-facing change?:

User has a possibility to modify Service type with "ingress_nginx_service_type" property in addons.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @chrxmvtik. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 15, 2024
@yankay
Copy link
Member

yankay commented Feb 18, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2024
@yankay
Copy link
Member

yankay commented Feb 18, 2024

Thanks @chrxmvtik
/approve
Would you please squash the commits?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2024
@chrxmvtik
feat/add default ingress-nginx service
129b264 
feat/add default ingress-nginx service

feat/add default ingress-nginx service

feat/add default ingress-nginx service
@chrxmvtik
Copy link
Contributor Author

Thanks @chrxmvtik /approve Would you please squash the commits?

Of course, commits are squashed now.

mzaian
mzaian approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chrxmvtik

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrxmvtik, mzaian, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a0d2bda into kubernetes-sigs:master Feb 19, 2024
65 checks passed
@mzaian mzaian mentioned this pull request Apr 26, 2024
Closed
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
@chrxmvtik @dibi-codes
feat/add default ingress-nginx service (kubernetes-sigs#10925)
8d38b90 
feat/add default ingress-nginx service

feat/add default ingress-nginx service

feat/add default ingress-nginx service
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@chrxmvtik @pedromcpedro
feat/add default ingress-nginx service (kubernetes-sigs#10925)
2d8b26c 
feat/add default ingress-nginx service

feat/add default ingress-nginx service

feat/add default ingress-nginx service
@mochizuki875 mochizuki875 mentioned this pull request Jun 20, 2024
Merged
@mochizuki875
Copy link
Member

/cherrypick release-2.24

@k8s-infra-cherrypick-robot
Copy link

@mochizuki875: new pull request created: #11330

In response to this:

/cherrypick release-2.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 27, 2024
Merged
@mochizuki875 mochizuki875 mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian mzaian approved these changes

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

Assignees

@mzaian mzaian

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chrxmvtik @k8s-ci-robot @yankay @mochizuki875 @k8s-infra-cherrypick-robot @mzaian