Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VIP parameters configurable #10927

Closed
blackliner opened this issue Feb 15, 2024 · 2 comments · Fixed by #11021
Closed

Make VIP parameters configurable #10927

blackliner opened this issue Feb 15, 2024 · 2 comments · Fixed by #11021
Assignees
@KubeKyrie
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@blackliner
Copy link
Contributor

What would you like to be added

I would like the following parameters to be configurable via ansible variables:

    - name: vip_leaseduration
      value: "5"
    - name: vip_renewdeadline
      value: "3"
    - name: vip_retryperiod
      value: "1"

Relevant file:

kubespray/roles/kubernetes/node/templates/manifests/kube-vip.manifest.j2

Lines 50 to 55 in 9648300

- name: vip_leaseduration
value: "5"
- name: vip_renewdeadline
value: "3"
- name: vip_retryperiod
value: "1"

Why is this needed

Some users have to increase the values to ~5x of their defaults, to prevent the kube-vip IP from being unreliable and jumping between nodes.

Reference: kube-vip/kube-vip#453 (comment)
@blackliner blackliner added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 15, 2024
@blackliner blackliner changed the title MAe VIP parameters configurable Make VIP parameters configurable Feb 15, 2024
@yankay
Copy link
Member

yankay commented Feb 20, 2024

Thanks @blackliner
If it's possible, welcome to provide a PR to improve. :-)

@KubeKyrie
Copy link
Contributor

/assign

@KubeKyrie KubeKyrie mentioned this issue Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KubeKyrie KubeKyrie

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make kube-vip LeaderElection variables configurable KubeKyrie/kubespray
3 participants
@yankay @blackliner @KubeKyrie