The committers are authorized under a signed CLA.

• ✅ Tim Geoghegan (a237e3d)

Welcome @tgeoghegan!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @tgeoghegan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

but it is still required for 0.9.0

Version 0.9.x required the creation of a Secret called memberlist. This Secret is now automatically created by the MetalLB controller if it does not already exist. To use this feature you must set the new ml-secret-name and deployment options or METALLB_ML_SECRET_NAME and METALLB_DEPLOYMENT environment variables. This is already done in the manifests provided with this release.

and this can confuse some users, since the creation of the secret seems the safest option and is compatible with 0.10.0 I prefer to keep it this way

The manifest linked to by the Kind metallb guide deploys quay.io/metallb/controller:main and quay.io/metallb/speaker:main, which by now are both well past 0.10, so someone who is following this guide today shouldn't need to worry about 0.9.x behavior. If they are making a point of using an older version of metallb, then one hopes they know what they are doing, and it shouldn't be necessary to clutter documentation for the 99% of users with tips for the 1%.

But I'm happy to defer to you and your colleagues as owners of this project. Feel free to close this PR.

The manifest linked to by the Kind metallb guide deploys quay.io/metallb/controller:main and quay.io/metallb/speaker:main, which by now are both well past 0.10, so someone who is following this guide today shouldn't need to worry about 0.9.x behavior. If they are making a point of using an older version of metallb, then one hopes they know what they are doing, and it shouldn't be necessary to clutter documentation for the 99% of users with tips for the 1%.

But I'm happy to defer to you and your colleagues as owners of this project. Feel free to close this PR.

nah, it is ok, thanks for doing the exercise,
/ok-to-test
/lgtm
/approve
Thanks

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, tgeoghegan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

@tgeoghegan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.