docs: drop bazel #2192
docs: drop bazel #2192
Conversation
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/assign @BenTheElder |
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tao12345666333
force-pushed
the
drop-bazel
branch
from
19fd845 to
30195c1
Compare
|
/test pull-kind-e2e-kubernetes-1-19 |
| @@ -115,7 +115,7 @@ See also: our own [contributor guide] and the Kubernetes [community page]. | |||
|
|
|||
| - kind supports multi-node (including HA) clusters | |||
| - kind supports building Kubernetes release builds from source | |||
| - support for make / bash / docker or bazel, in addition to pre-published builds | |||
| - support for make / bash or docker, in addition to pre-published builds | |||
There was a problem hiding this comment.
this is the same thing currently, we should drop this bullet. can do that nit in a follow up as cleaning up bazel on it's own is worth it
| @@ -51,7 +51,7 @@ func NewCommand(logger log.Logger, streams cmd.IOStreams) *cobra.Command { | |||
| } | |||
| cmd.Flags().StringVar( | |||
| &flags.BuildType, "type", | |||
| "docker", "build type, one of [bazel, docker]", | |||
| "docker", "build type, default is docker", | |||
There was a problem hiding this comment.
TODO: document deprecation in usage and/or hide flag
|
/lgtm |
|
thank you! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
No description provided.