don't use loopback addresses on the nodes resolv.conf file #2165
Conversation
k8s-ci-robot
added
approved
|
/assign @BenTheElder |
we were using the well known name host.docker.internal to get the host IP address, however, it seems that in some systems it resolves to a loopback address. We use this address to replace the embedded docker dns IP address in the resolv.conf. We can't use a loopback address, because coredns obtains the upstream dns resolvers from the resolv.conf, and evidentelly, it crashes if the upstream DNS resolver is a loopback, because it meains that is itself, and that is a loop.
|
PR title seems inaccurate. |
oh yeah, because at first I though that we could use directly that, until I realise window and mac needs to resolve |
aojea
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
That test sounds bogus with concurrent watches 🤔 |
|
/retest |
|
/retest
|
we were using the well known name host.docker.internal to get the
host IP address, however, it seems that in some systems it resolves
to a loopback address. We use this address to replace the embedded
docker dns IP address in the resolv.conf.
We can't use a loopback address, because coredns obtains the upstream
dns resolvers from the resolv.conf, and evidentelly, it crashes if the
upstream DNS resolver is a loopback, because it meains that is itself,
and that is a loop.
Fixes: #1975