Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade base image #1528

Merged
merged 4 commits into from
May 1, 2020
Merged

upgrade base image #1528

merged 4 commits into from
May 1, 2020

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Apr 29, 2020

Upgrade base image to 20.04

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 29, 2020
@k8s-ci-robot k8s-ci-robot requested review from amwat and munnerz April 29, 2020 17:10
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2020
@ameukam
Copy link
Member Author

ameukam commented Apr 30, 2020

/retest

@BenTheElder
Copy link
Member

/cc

@ameukam
Copy link
Member Author

ameukam commented Apr 30, 2020

/test pull-kind-e2e-kubernetes-1-18

@ameukam
Copy link
Member Author

ameukam commented Apr 30, 2020

Also tests will be skipped for 1.12-1.14: kubernetes/test-infra#17443

@aojea
Copy link
Contributor

aojea commented Apr 30, 2020

/hold

let's wait for CNI 0.8.6, I was told they are going to release it this week, and it has a change in the portmap plugin I'm interested in see how it goes

can you add this change @ameukam
CNI_VERSION="v0.8.3" -> v0.8.6

I'll ping you once it has been released

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2020
@ameukam ameukam force-pushed the update-base-image branch from 3e96009 to 238c477 Compare April 30, 2020 07:26
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2020
@BenTheElder
Copy link
Member

I'd just as soon upgrade CNI seperately, easier to track down issues :-)

didn't touch this prior to finishing 0.8, but that's done now so let's go :-)

@BenTheElder BenTheElder force-pushed the update-base-image branch from 238c477 to f580946 Compare May 1, 2020 03:50
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2020
@BenTheElder
Copy link
Member

rebased, pushing an image

@ameukam @BenTheElder
Upgrade base image and tools
6548f19 
Update base image to Ubuntu focal:
https://wiki.ubuntu.com/FocalFossa/ReleaseNotes

Update cri-tools to 1.17.0: https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.17.0

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@BenTheElder BenTheElder force-pushed the update-base-image branch from f580946 to 6548f19 Compare May 1, 2020 03:52
@BenTheElder BenTheElder changed the title [WIP] upgrade base image upgrade base image May 1, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2020
@BenTheElder
Copy link
Member

added crictl v1.18.0

@BenTheElder
Copy link
Member

/hold cancel
/lgtm
/approve
thanks!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2020
@BenTheElder BenTheElder added this to the v0.9.0 milestone May 1, 2020
@BenTheElder
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 38f9bf5 into kubernetes-sigs:master May 1, 2020
BenTheElder
BenTheElder reviewed May 1, 2020
View reviewed changes
images/base/Dockerfile
@@ -19,15 +19,15 @@

# start from ubuntu 19.10, this image is reasonably small as a starting point
# for a kubernetes node image, it doesn't contain much we don't need
FROM ubuntu:19.10
FROM ubuntu:20.04

# Configure containerd and runc binaries from kind-ci/containerd-nightlies repository
# The repository contains latest stable releases and nightlies built for multiple architectures
ARG CONTAINERD_VERSION="v1.3.3-14-g449e9269"
# Configure CNI binaries from upstream
ARG CNI_VERSION="v0.8.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll come back for this when it's out

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no probl, I was expecting a release this week, but it wasn't the case obviously :)

@BenTheElder BenTheElder mentioned this pull request Jun 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@amwat amwat Awaiting requested review from amwat

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ameukam @BenTheElder @aojea @k8s-ci-robot