Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvement on seccomp test. #144

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Minor improvement on seccomp test. #144

merged 1 commit into from
Sep 21, 2017

Conversation

Random-Liu
Copy link
Contributor

In previous test, we don't know whether it's the default capability list blocks sethostname or seccomp does.

With this PR, we'll explicitly set SYS_ADMIN, which should allow sethostname when seccomp is unconfined; and seccomp should be able to block sethostname even when SYS_ADMIN exists.

Signed-off-by: Lantao Liu lantaol@google.com

@Random-Liu
Improve seccomp test.
b9592bf 
Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 21, 2017
@feiskyer
Copy link
Member

LGTM

@feiskyer feiskyer added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2017
@feiskyer feiskyer requested a review from mikebrow September 21, 2017 09:49
mikebrow
mikebrow approved these changes Sep 21, 2017
View reviewed changes
Copy link
Contributor

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@Random-Liu Random-Liu merged commit 1a56c31 into kubernetes-sigs:master Sep 21, 2017
@Random-Liu Random-Liu deleted the improve-seccomp-test branch September 21, 2017 18:37
@Random-Liu
Copy link
Contributor Author

@mikebrow @feiskyer Thanks for reviewing!

@feiskyer feiskyer mentioned this pull request Sep 22, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikebrow mikebrow mikebrow approved these changes

Assignees

@feiskyer feiskyer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Random-Liu @feiskyer @mikebrow @k8s-ci-robot