Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3857: Recursive Read-only (RRO) mounts #1344

Merged
merged 1 commit into from
Mar 4, 2024
Merged

KEP-3857: Recursive Read-only (RRO) mounts #1344

merged 1 commit into from
Mar 4, 2024

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Feb 7, 2024 •
edited
Loading

Depends on:

Depended by:

What type of PR is this?

/kind feature

What this PR does / why we need it:

Implement KEP-3857: Recursive Read-only (RRO) mounts

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support Recursive Read-only (RRO) mounts  (KEP-3857)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 7, 2024
@AkihiroSuda AkihiroSuda mentioned this pull request Feb 7, 2024
Merged
2 tasks
@AkihiroSuda AkihiroSuda changed the title [WIP] KEP-3857: Recursive Read-only (RRO) mounts KEP-3857: Recursive Read-only (RRO) mounts Feb 7, 2024
This was referenced Feb 7, 2024
Merged
Merged
Open
@AkihiroSuda AkihiroSuda force-pushed the rro branch 2 times, most recently from 674c5ad to eb84fe5 Compare February 8, 2024 12:47
@AkihiroSuda AkihiroSuda mentioned this pull request Feb 13, 2024
Merged
@AkihiroSuda AkihiroSuda marked this pull request as ready for review February 17, 2024 14:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2024
@kannon92
Copy link
Contributor

@AkihiroSuda is this required as part of the KEP merge? Just trying to gauge priority and if we should get some reviews before freeze?

@haircommander
Copy link
Contributor

cri-tools has a less strict release cycle than kubernetes. We can merge this after kubernetes freeze if we need to.

@AkihiroSuda
Copy link
Member Author

containerd/containerd#9787 was already merged, so we'd like to see this critest to be available in the upstream soon

@AkihiroSuda
Copy link
Member Author

Rebased

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 29, 2024
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Feb 29, 2024 •
edited
Loading

critest CRI-O / main / linux amd64 (pull_request) Failing after 2m

This failure is an issue of CRI-O (it reports that it implements RRO, but actually it does not)
https://github.com/cri-o/cri-o/pull/7765/files#r1506892815

@AkihiroSuda AkihiroSuda mentioned this pull request Feb 29, 2024
Merged
@saschagrunert saschagrunert mentioned this pull request Feb 29, 2024
Merged
@AkihiroSuda AkihiroSuda force-pushed the rro branch 2 times, most recently from 51dbdb3 to e853e41 Compare February 29, 2024 13:34
@saschagrunert
Copy link
Member

saschagrunert commented Feb 29, 2024 •
edited
Loading

I'm going to rebuild the CRI-O bundle in https://github.com/cri-o/packaging/actions/runs/8096897942, after that the CI should pick-up the merge of cri-o/cri-o#7828

Edit: Done ✔️

saschagrunert
saschagrunert reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, otherwise LGTM

pkg/validate/container_linux.go Outdated Show resolved Hide resolved
@AkihiroSuda
KEP-3857: Recursive Read-only (RRO) mounts
94ca2fc 
See kubernetes/enhancements issue 3857 (PR 3858)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit fffa484 into kubernetes-sigs:master Mar 4, 2024
23 checks passed
@AkihiroSuda AkihiroSuda mentioned this pull request Mar 4, 2024
Merged
@kwilczynski kwilczynski mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@haircommander haircommander Awaiting requested review from haircommander

@klueska klueska Awaiting requested review from klueska

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AkihiroSuda @kannon92 @haircommander @saschagrunert @k8s-ci-robot