This repository has been archived by the owner on May 22, 2020. It is now read-only.
Standardize ProviderConfig for Cluster and Machine #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
needs-ok-to-test
In order to maintain type parity for providerConfig across both Machine and Cluster types, change the ClusterSpec.ProviderConfig to the ProviderConfig type. Additionally, as all changes to the API require regenerating code, add a Makefile that will simplify that process. Signed-off-by: Craig Tracey <craigtracey@gmail.com>
craigtracey
force-pushed
the
cluster-provider-config
branch
from
88b12e9 to
bc2aab4
Compare
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/assign krousey cc @krousey |
krousey
suggested changes
Apr 9, 2018
|
|
||
| // No more than one of the following may be specified. | ||
|
|
||
| // Value is an inlined, serialized representation of the node |
There was a problem hiding this comment.
remove "node" and replace appropriately.
|
|
||
| import runtime "k8s.io/apimachinery/pkg/runtime" | ||
|
|
||
| // ProviderConfig defines the configuration to use during node creation. |
cluster-api/Makefile
Outdated
| all: genapi genconversion | ||
|
|
||
| genapi: | ||
| go get -u github.com/kubernetes-incubator/apiserver-builder/cmd/apiregister-gen |
There was a problem hiding this comment.
This means we're always using the tool at head. Is it possible to vendor, build from vendor, and use that copy?
cluster-api/Makefile
Outdated
| apiregister-gen -i ./pkg/apis,./pkg/apis/cluster/v1alpha1 | ||
|
|
||
| genconversion: | ||
| go get -u k8s.io/code-generator/cmd/conversion-gen |
There was a problem hiding this comment.
Same vendoring comment for this.
Modify the dep config to lock our codegen dependencies and make use of these dependencies in a top-level Makefile. Signed-off-by: Craig Tracey <craigtracey@gmail.com>
Updating vendor dependencies in response to introduction of k8s.io/code-generator. Signed-off-by: Craig Tracey <craigtracey@gmail.com>
As this code has moved from being Machine-specific to being generic, remove references to "node" in favor of "resource." "resource" has been chosen as this type may be leveraged by any type that would like to implement "providerConfig" semantics. Signed-off-by: Craig Tracey <craigtracey@gmail.com>
k8s-ci-robot
added
size/XXL
krousey
approved these changes
Apr 10, 2018
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: craigtracey, krousey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In order to maintain type parity for providerConfig across both Machine
and Cluster types, change the ClusterSpec.ProviderConfig to the
ProviderConfig type.
Additionally, as all changes to the API require regenerating code, add a
Makefile that will simplify that process.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note:
@kubernetes/kube-deploy-reviewers