Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

Fix renaming of "runtime" container to "docker-daemon" #1656

Merged
merged 1 commit into from
May 25, 2017
Merged

Fix renaming of "runtime" container to "docker-daemon" #1656

merged 1 commit into from
May 25, 2017

Conversation

loburm
Copy link
Contributor

@loburm loburm commented May 22, 2017 •
edited
Loading

This PR fix #1639. Previously all containers named "runtime" have been renamed to "docker-daemon" (that's because reverse procedure was done in kubernetes). Now we are renaming to "docker-daemon" only system containers to avoid cases when container which was originally named as "runtime" renamed to "docker-daemon".

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 22, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @loburm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 22, 2017
@DirectXMan12
Copy link
Contributor

DirectXMan12 commented May 22, 2017 •
edited
Loading

@piosz didn't you just fix this? whoops, I think I just saw this issue before.

@DirectXMan12
Copy link
Contributor

Please provide a more detailed description in both the commit body and the PR description. Please try also to not have too long of a commit message title (otherwise it wraps).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 25, 2017
@loburm
Copy link
Contributor Author

loburm commented May 25, 2017

Thanks for the comments, I have updated PR description and commit title.
cc @timstclair

@loburm loburm changed the title Fix an issue when a container named to "runtime" renamed to "docker-daemon" Fix renaming of "runtime" container to "docker-daemon" May 25, 2017
@piosz
Copy link
Contributor

piosz commented May 25, 2017

/lgtm
/approve
Thanks @loburm for the fix. Could you please cherry-pick this to release-1.3?

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2017
@piosz
Copy link
Contributor

piosz commented May 25, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 25, 2017
@loburm loburm mentioned this pull request May 25, 2017
Merged
@piosz piosz merged commit d6741b3 into kubernetes-retired:master May 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Containers "runtime" are renamed to "docker-daemon"
6 participants
@loburm @k8s-ci-robot @k8s-reviewable @DirectXMan12 @piosz @googlebot