Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

Implementation of Metrics API operations #1152

Merged
merged 1 commit into from
May 13, 2016
Merged

Implementation of Metrics API operations #1152

merged 1 commit into from
May 13, 2016

Conversation

piosz
Copy link
Contributor

@piosz piosz commented May 10, 2016 •
edited
Loading

ref kubernetes/kubernetes#23376

Initial implementation - there is still a bunch of things to implement, added todos in the code.

should be merged after #1151

cc @davidopp @fgrzadkowski

@k8s-bot
Copy link

k8s-bot commented May 10, 2016

Jenkins GCE e2e

Build/test failed for commit 0c1fa17.

@piosz piosz force-pushed the metrics-api-impl branch from 0c1fa17 to d646a0e Compare May 10, 2016 18:43
@k8s-bot
Copy link

k8s-bot commented May 10, 2016

Jenkins GCE e2e

Build/test failed for commit d646a0e.

@piosz piosz mentioned this pull request May 11, 2016
Closed
4 tasks
@piosz piosz force-pushed the metrics-api-impl branch from d646a0e to 4310fa9 Compare May 12, 2016 09:44
@k8s-bot
Copy link

k8s-bot commented May 12, 2016

Jenkins GCE e2e

Build/test failed for commit 4310fa9.

mwielgus
mwielgus reviewed May 12, 2016
View reviewed changes
metrics/apis/metrics/handlers.go
@@ -0,0 +1,187 @@
// Copyright 2015 Google Inc. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2016 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@piosz piosz force-pushed the metrics-api-impl branch from 4310fa9 to 6f96e58 Compare May 13, 2016 09:11
@k8s-bot
Copy link

k8s-bot commented May 13, 2016

Jenkins GCE e2e

Build/test failed for commit 6f96e58.

@mwielgus
Copy link
Contributor

LGTM

@mwielgus mwielgus merged commit d7ec622 into kubernetes-retired:master May 13, 2016
@piosz piosz deleted the metrics-api-impl branch May 13, 2016 12:50
@piosz piosz added the lgtm Indicates that a PR is ready to be merged. label May 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piosz @k8s-bot @mwielgus @googlebot