add recording rules to get inodes data #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuo
changed the title
metalmatze
requested changes
Nov 28, 2018
| * on (host_ip) group_right (node) | ||
| label_replace( | ||
| (max(node_filesystem_files_free{mountpoint="/"}) by (instance)), "host_ip", "$1", "instance", "(.*):.*" | ||
| ) |
There was a problem hiding this comment.
I've pushed a new commit for this PR to address the concerns you raised.
Let me know if it's ok or not
Thanks
Ben
There was a problem hiding this comment.
Is there anything else I should change ?
There was a problem hiding this comment.
No, I just need some time to test the dashboard. 😉
Signed-off-by: Benjamin <benjamin@yunify.com>
|
LGTM. Any more comments @brancz @tomwilkie? |
metalmatze
approved these changes
Dec 5, 2018
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add prometheus rules to get inodes data
verified in production env