Make disk device name selector configurable #117
Conversation
|
Maybe it makes sense to do the same as the fsTypes? kubernetes-mixin/config.libsonnet Lines 55 to 57 in 1595151 |
cbeneke
force-pushed
the
configuruable-disk-device
branch
from
4e1722f to
16d5f19
Compare
|
Imho this just complicates things, but as you can still overwrite the Selector I'm fine with that^^ Updated |
|
Maybe we should also add rbd |
|
I just used the existing common disk-identifiers as before. I guess as defaults it is useful to just use the big common providers (google, aws, azure?) and typical linux disk device names, which should be sd* (google, azure, local), xvd* (aws) and nvme* (aws ssd, local). Not sure, if there are typical other namings for those providers though :) |
|
rbd means rados-block-device. This disk values are quiet important for ceph users. |
This adds rbd (Rados Block Storage) and vd (KVM default devices) to the list of default diskDevices.
cbeneke
force-pushed
the
configuruable-disk-device
branch
from
16d5f19 to
42e0f4f
Compare
|
Yeah.. But as I argued in my answer before, I'm not sure how common Ceph disk devices actually are. Nonetheless I added a second commit adding |
|
I would almost argue that we only have a very few examples and that's it. It's quite simple to set what you exactly need. Nonetheless it has been worked on now, so I'm find with this. |
If your cluster runs with different diskselectors the recording rules for disks are broken (e.g. KVM default is vd[a-z]). This PR makes the selector configurable