Promote ephemeral storage quota to beta(1.31) #46967

PannagaRao · 2024-06-25T14:12:54Z

Promote LocalStorageCapacityIsolationFSQuotaMonitoring to beta
KEP reference: kubernetes/enhancements#4679

netlify · 2024-06-25T14:13:10Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`97899e0`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66a7d7687925ad0008ca448b

netlify · 2024-06-25T14:15:47Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`97899e0`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a7d7685e13c10008ed94ef
😎 Deploy Preview	https://deploy-preview-46967--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dipesh-rawat · 2024-06-25T14:55:29Z

/sig node

Ritikaa96 · 2024-06-25T16:39:04Z

Is this a work in progress? if yes, please add the label do-not-merge/work-in-progress' as i don't see any change here.

k8s-ci-robot · 2024-06-25T17:06:30Z

@PannagaRao: The label(s) /label work-in-progress cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label work-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2024-06-25T17:11:52Z

@PannagaRao: The label(s) /label do-not-merge cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label do-not-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hacktivist123 · 2024-07-08T09:32:03Z

Hi @RobertKrawitz @pacoxu @PannagaRao, 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday, July 16th, 2024 18:00 PST. Thank you!

Princesso · 2024-07-15T07:48:44Z

Hi @PannagaRao, a gentle reminder that tomorrow is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday, July 16th, 2024 18:00 PST.

tengqm · 2024-07-23T23:23:03Z

...d-line-tools-reference/feature-gates/local-storage-capacity-isolation-fs-quota-monitoring.md

+[local ephemeral storage](/docs/concepts/configuration/manage-resources-containers/), 
+the backing filesystem for [emptyDir volumes](/docs/concepts/storage/volumes/#emptydir) supports project quotas,
+and `UserNamespacesSupport` is enabled, 
+project quotas are used to monitor [emptyDir volume](/docs/concepts/storage/volumes/#emptydir) storage consumption rather than using filesystem walk, ensuring better performance and accuracy.


nit: wrap the long line, and remove the extra hyperlink.

Suggested change

project quotas are used to monitor [emptyDir volume](/docs/concepts/storage/volumes/#emptydir) storage consumption rather than using filesystem walk, ensuring better performance and accuracy.

project quotas are used to monitor emptyDir volume storage consumption rather than

using filesystem walk, ensuring better performance and accuracy.

dipesh-rawat · 2024-07-23T23:30:33Z

content/en/docs/concepts/configuration/manage-resources-containers.md

@@ -463,7 +463,7 @@ that file but the kubelet does not categorize the space as in use.
 {{% /tab %}}
 {{% tab name="Filesystem project quota" %}}

-{{< feature-state for_k8s_version="v1.15" state="alpha" >}}
+{{< feature-state for_k8s_version="v1.31" state="beta" >}}


Consider using the "feature_gate_name" option for feature-state shortcode. This will make it more data-driven by pulling from the feature gate description file.

Suggested change

{{< feature-state for_k8s_version="v1.31" state="beta" >}}

{{< feature-state feature_gate_name="LocalStorageCapacityIsolationFSQuotaMonitoring" >}}

pacoxu

/lgtm

hacktivist123 · 2024-07-25T09:44:35Z

/assign sftim

content/en/docs/concepts/configuration/manage-resources-containers.md

sftim · 2024-07-25T11:54:51Z

...d-line-tools-reference/feature-gates/local-storage-capacity-isolation-fs-quota-monitoring.md

BTW we'd typically write emptyDir inside backticks.

sftim · 2024-07-25T11:56:07Z

For beta, I'd like the advice about enabling it tweaked (so that people can see it's on by default).

See #46967 (comment)
/lgtm cancel

Tech LGTM noted.

tengqm · 2024-07-26T01:01:22Z

...d-line-tools-reference/feature-gates/local-storage-capacity-isolation-fs-quota-monitoring.md

@@ -9,11 +9,14 @@ stages:
  - stage: alpha
    defaultValue: false
    fromVersion: "1.15"
+    toVersion: "1.30"
+  - stage: beta 
+    defaultValue: true


is the default still "true"?

Changed the defaultValue to false

Princesso · 2024-07-29T12:02:46Z

Hello @PannagaRao,

v1.31 Doc Lead here. This PR has been marked as at risk for Doc Freeze.

The Doc Reviewers have given feedback on it, however, an update is yet to be made on it, based on feedback.

Please note that the Doc freeze deadline is tomorrow, and if the PR is not merged by tomorrow, you will need to file an exception or this enhancement will be removed from this release. Thank you!

sftim · 2024-07-29T15:36:14Z

content/en/docs/concepts/configuration/manage-resources-containers.md

+* Disable the `LocalStorageCapacityIsolationFSQuotaMonitoring`
+  [feature gate](/docs/reference/command-line-tools-reference/feature-gates/)
+  using the `featureGates` field in the
+  [kubelet configuration](/docs/reference/config-api/kubelet-config.v1beta1/)
+  or the `--feature-gates` command line flag.


Is this right?

BTW I think --feature-gates is deprecated, and (nit) it's a command line argument not a flag.

Changed this line. Please take a look.

Signed-off-by: PannagaRamamanohara <pbhojara@redhat.com>

Princesso · 2024-07-30T12:53:57Z

/assign @sftim

sftim

Thanks
/lgtm
/approve

sftim · 2024-07-30T13:42:50Z

content/en/docs/concepts/configuration/manage-resources-containers.md

+  [feature gate](/docs/reference/command-line-tools-reference/feature-gates/)
+  using the `featureGates` field in the
+  [kubelet configuration](/docs/reference/config-api/kubelet-config.v1beta1/).


Could write:

Suggested change

[feature gate](/docs/reference/command-line-tools-reference/feature-gates/)

using the `featureGates` field in the

[kubelet configuration](/docs/reference/config-api/kubelet-config.v1beta1/).

Disable the `LocalStorageCapacityIsolationFSQuotaMonitoring`

[feature gate](/docs/reference/command-line-tools-reference/feature-gates/)

using the `featureGates` field in the

[kubelet configuration](/docs/reference/config-api/kubelet-config.v1beta1/).

(`LocalStorageCapacityIsolationFSQuotaMonitoring` is disabled by default).

k8s-ci-robot · 2024-07-30T13:43:09Z

LGTM label has been added.

Git tree hash: edb7a1dc5672d1eb1782ef3477b3b3a83a24ca85

k8s-ci-robot · 2024-07-30T13:43:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/docs/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ffromani · 2024-07-30T13:47:04Z

LGTM for sig-node content, but non-binding because my very limited experience in the area

k8s-ci-robot added this to the 1.31 milestone Jun 25, 2024

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2024

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 25, 2024

PannagaRao marked this pull request as draft June 25, 2024 17:15

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024

PannagaRao changed the title ~~Promote ephemeral storage quota to beta(1.31)~~ [WIP] Promote ephemeral storage quota to beta(1.31) Jun 25, 2024

haircommander mentioned this pull request Jun 27, 2024

Quotas for Ephemeral Storage kubernetes/enhancements#1029

Open

22 tasks

PannagaRao force-pushed the promote-xfsQuota-to-beta branch from ddab1f3 to 9fce41c Compare July 17, 2024 19:39

PannagaRao closed this Jul 17, 2024

PannagaRao force-pushed the promote-xfsQuota-to-beta branch from 9fce41c to 6786d24 Compare July 17, 2024 19:42

PannagaRao force-pushed the promote-xfsQuota-to-beta branch 2 times, most recently from 9ecd168 to c70c19e Compare July 23, 2024 16:48

tengqm reviewed Jul 23, 2024

View reviewed changes

dipesh-rawat reviewed Jul 23, 2024

View reviewed changes

pacoxu approved these changes Jul 25, 2024

View reviewed changes

k8s-ci-robot assigned pacoxu Jul 25, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024

k8s-ci-robot assigned sftim Jul 25, 2024

sftim reviewed Jul 25, 2024

View reviewed changes

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024

k8s-ci-robot requested review from pacoxu and sftim July 25, 2024 11:56

PannagaRao force-pushed the promote-xfsQuota-to-beta branch from 12deced to c9c0e2b Compare July 25, 2024 14:40

tengqm reviewed Jul 26, 2024

View reviewed changes

PannagaRao force-pushed the promote-xfsQuota-to-beta branch from f1f5618 to 8b62420 Compare July 29, 2024 15:31

sftim reviewed Jul 29, 2024

View reviewed changes

PannagaRao force-pushed the promote-xfsQuota-to-beta branch from 8c7fb3a to b3aa376 Compare July 29, 2024 17:33

update LocalStorageCapacityIsolationFSQuotaMonitoring to beta

97899e0

Signed-off-by: PannagaRamamanohara <pbhojara@redhat.com>

PannagaRao force-pushed the promote-xfsQuota-to-beta branch from 48837e5 to 97899e0 Compare July 29, 2024 17:54

sftim reviewed Jul 30, 2024

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2024

k8s-ci-robot merged commit d879656 into kubernetes:dev-1.31 Jul 30, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote ephemeral storage quota to beta(1.31) #46967

Promote ephemeral storage quota to beta(1.31) #46967

PannagaRao commented Jun 25, 2024

netlify bot commented Jun 25, 2024 •

edited

Loading

netlify bot commented Jun 25, 2024 •

edited

Loading

dipesh-rawat commented Jun 25, 2024

Ritikaa96 commented Jun 25, 2024

k8s-ci-robot commented Jun 25, 2024

k8s-ci-robot commented Jun 25, 2024

hacktivist123 commented Jul 8, 2024

Princesso commented Jul 15, 2024

tengqm Jul 23, 2024

dipesh-rawat Jul 23, 2024

pacoxu left a comment

hacktivist123 commented Jul 25, 2024

sftim Jul 25, 2024

sftim commented Jul 25, 2024

tengqm Jul 26, 2024

PannagaRao Jul 29, 2024

Princesso commented Jul 29, 2024

sftim Jul 29, 2024

PannagaRao Jul 29, 2024

Princesso commented Jul 30, 2024 •

edited

Loading

sftim left a comment

sftim Jul 30, 2024

k8s-ci-robot commented Jul 30, 2024

k8s-ci-robot commented Jul 30, 2024

ffromani commented Jul 30, 2024

	project quotas are used to monitor [emptyDir volume](/docs/concepts/storage/volumes/#emptydir) storage consumption rather than using filesystem walk, ensuring better performance and accuracy.
	project quotas are used to monitor emptyDir volume storage consumption rather than
	using filesystem walk, ensuring better performance and accuracy.

	{{< feature-state for_k8s_version="v1.31" state="beta" >}}
	{{< feature-state feature_gate_name="LocalStorageCapacityIsolationFSQuotaMonitoring" >}}

Promote ephemeral storage quota to beta(1.31) #46967

Promote ephemeral storage quota to beta(1.31) #46967

Conversation

PannagaRao commented Jun 25, 2024

netlify bot commented Jun 25, 2024 • edited Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

netlify bot commented Jun 25, 2024 • edited Loading

✅ Pull request preview available for checking

dipesh-rawat commented Jun 25, 2024

Ritikaa96 commented Jun 25, 2024

k8s-ci-robot commented Jun 25, 2024

k8s-ci-robot commented Jun 25, 2024

hacktivist123 commented Jul 8, 2024

Princesso commented Jul 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pacoxu left a comment

Choose a reason for hiding this comment

hacktivist123 commented Jul 25, 2024

Choose a reason for hiding this comment

sftim commented Jul 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Princesso commented Jul 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Princesso commented Jul 30, 2024 • edited Loading

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 30, 2024

k8s-ci-robot commented Jul 30, 2024

ffromani commented Jul 30, 2024

netlify bot commented Jun 25, 2024 •

edited

Loading

netlify bot commented Jun 25, 2024 •

edited

Loading

Princesso commented Jul 30, 2024 •

edited

Loading