Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark TopologyManager feature gate as removed in v1.29 #43554

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Mark TopologyManager feature gate as removed in v1.29 #43554

merged 1 commit into from
Oct 19, 2023

Conversation

tukwila
Copy link
Contributor

@tukwila tukwila commented Oct 18, 2023

Move feature gates TopologyManager to feature-gates-removed page
Ref: kubernetes/kubernetes#121252

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Oct 18, 2023
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 18, 2023
@netlify
Copy link

netlify bot commented Oct 18, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 502d8c6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/653094cb72de1000086c4631
😎 Deploy Preview https://deploy-preview-43554--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tukwila tukwila mentioned this pull request Oct 18, 2023
Merged
@tengqm
Copy link
Contributor

tengqm commented Oct 18, 2023

Please limit your change to English only, in this PR.
Do not touch other localization files.

@tukwila
remove TopologyManager from website
502d8c6 
add TopologyManager in feature-gates-removed md

Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
@tukwila tukwila force-pushed the TopologyManager-remove branch from 33e58b5 to 502d8c6 Compare October 19, 2023 02:30
@tukwila
Copy link
Contributor Author

tukwila commented Oct 19, 2023

Please limit your change to English only, in this PR. Do not touch other localization files.

yes, i restored.

@tengqm
Copy link
Contributor

tengqm commented Oct 19, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 73eba83a553c3f1b3368c3025138f3e941894809

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 11b2dcd into kubernetes:main Oct 19, 2023
3 checks passed
@sftim sftim mentioned this pull request Oct 20, 2023
Closed
@sftim
Copy link
Contributor

sftim commented Oct 20, 2023

/retitle Mark TopologyManager feature gate as removed in v1.29

@k8s-ci-robot k8s-ci-robot changed the title Topology manager remove Mark TopologyManager feature gate as removed in v1.29 Oct 20, 2023
@sftim
Copy link
Contributor

sftim commented Oct 20, 2023

/remove-language ja
/remove-language ko
/remove-language zh

@k8s-ci-robot k8s-ci-robot removed language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language labels Oct 20, 2023
@reylejano
Copy link
Member

this probably should have been to the dev-1.29 branch

@dipesh-rawat dipesh-rawat mentioned this pull request Oct 20, 2023
Merged
@tengqm
Copy link
Contributor

tengqm commented Oct 21, 2023

Oops, my bad.

@tengqm
Copy link
Contributor

tengqm commented Oct 21, 2023

With the revert PR merged, we need a new one that targets dev-1.29.

@reylejano reylejano mentioned this pull request Oct 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bells17 bells17 Awaiting requested review from bells17

@howieyuen howieyuen Awaiting requested review from howieyuen

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tukwila @tengqm @k8s-ci-robot @sftim @reylejano