Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the interactive tutorials in Russian without Katacoda #42530

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Updating the interactive tutorials in Russian without Katacoda #42530

merged 1 commit into from
Aug 16, 2023

Conversation

shurup
Copy link
Member

@shurup shurup commented Aug 14, 2023

Fixes #41923

All tutorials where Katacoda was in use are now synchronised with their actual English editions. I also had to make a general overhaul for these pages fixing many things and applying consistent wording for terms, etc.

@Arhell @kirkonru: I kindly ask you to find some time to go through this ASAP. Anyway, I want this to go live in a week. These updates are essential for users, and rendering them took a lot of time, so I don't want to postpone them much more. We'll be better able to fix any issues later.

@shurup shurup added language/ru Issues or PRs related to Russian language area/localization General issues or PRs related to localization labels Aug 14, 2023
@shurup shurup requested a review from Arhell August 14, 2023 09:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 14, 2023
@netlify
Copy link

netlify bot commented Aug 14, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5b3bd3c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64dcd5d19a56380008fee66a
😎 Deploy Preview https://deploy-preview-42530--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Arhell
Arhell reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bfe2d2a79c59d487e49aaeec5f1ec62d80eed759

kirkonru
kirkonru approved these changes Aug 16, 2023
View reviewed changes
content/ru/docs/tutorials/hello-minikube.md Outdated Show resolved Hide resolved
content/ru/docs/tutorials/hello-minikube.md Outdated Show resolved Hide resolved
content/ru/docs/tutorials/kubernetes-basics/create-cluster/cluster-intro.html Outdated Show resolved Hide resolved
content/ru/docs/tutorials/kubernetes-basics/create-cluster/cluster-intro.html Outdated Show resolved Hide resolved
data/i18n/ru/ru.toml Outdated Show resolved Hide resolved
content/ru/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
content/ru/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
content/ru/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
content/ru/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
content/ru/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot k8s-ci-robot requested a review from Arhell August 16, 2023 13:28
@Arhell
Copy link
Member

Arhell commented Aug 16, 2023

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 16, 2023
@shurup @kirkonru
Translating and fixing the interactive tutorials in Russian
5b3bd3c 
Co-authored-by: Kirill Kononovich <41591254+kirkonru@users.noreply.github.com>
@shurup shurup force-pushed the ru-remove-katacoda branch from fcf9e1d to 5b3bd3c Compare August 16, 2023 13:57
@shurup
Copy link
Member Author

shurup commented Aug 16, 2023

Oh, I've just squashed everything :)
Thanks, @kirkonru, for all corrections! We are ready to go now.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@shurup: you cannot LGTM your own PR.

In response to this:

Oh, I've just squashed everything :)
Thanks, @kirkonru, for all corrections! We are ready to go now.

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kirkonru, shurup

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@Arhell
Copy link
Member

Arhell commented Aug 16, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0236c0c3e8ad8e67f89ca60e18afe6901ed8c5ac

@shurup
Copy link
Member Author

shurup commented Aug 16, 2023

Thanks, @Arhell!

@k8s-ci-robot k8s-ci-robot merged commit 4d8feb6 into kubernetes:main Aug 16, 2023
@shurup shurup mentioned this pull request Aug 17, 2023
Closed
@kirkonru kirkonru mentioned this pull request Feb 13, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkonru kirkonru kirkonru approved these changes

@bradtopol bradtopol Awaiting requested review from bradtopol

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@Arhell Arhell Awaiting requested review from Arhell

Assignees

@Arhell Arhell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ru Issues or PRs related to Russian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ru] Remove Katacoda tutorials and update instructions
4 participants
@shurup @k8s-ci-robot @Arhell @kirkonru