Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1.28 to release schedule for 1.28 release #42254

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Add 1.28 to release schedule for 1.28 release #42254

merged 4 commits into from
Aug 15, 2023

Conversation

Rishit-dagli
Copy link
Member

This PR adds 1.28 to the releases schedule for the 1.28.0 release
/milestone 1.28

@k8s-ci-robot k8s-ci-robot modified the milestone: 1.28 Jul 27, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2023
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jul 27, 2023
@netlify
Copy link

netlify bot commented Jul 27, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit e2257a8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64d80db77697ac0009caba33

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2023
sftim
sftim reviewed Jul 27, 2023
View reviewed changes
data/releases/schedule.yaml Outdated Show resolved Hide resolved
sftim
sftim reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

OK to unhold if either:

  • the date of release is 100% confirmed
  • the date of release is not confirmed, but SIG Release are tracking any rework on this change if the release happens on a different date

data/releases/schedule.yaml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2023
Rishit-dagli and others added 2 commits August 7, 2023 12:09
@Rishit-dagli @sftim
Update data/releases/schedule.yaml
271f86e 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@Rishit-dagli @sftim
Update data/releases/schedule.yaml
a8ba9b8 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2023
@sftim
Copy link
Contributor

sftim commented Aug 7, 2023 •
edited
Loading

The build error:
Error building site: /opt/build/repo/content/en/releases/patch-releases.md:88:1: failed to render shortcode release-branches: failed to process shortcode: /opt/build/repo/layouts/shortcodes/release-branches.html:16:17: execute of template failed: template: shortcodes/release-branches.html:16:17: executing shortcodes/release-branches.html at <time.Format>: error calling Format: unable to cast <nil> of type <nil> to Time

sftim
sftim reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to set maintenanceModeStartDate (or change the shortcode to allow that field to be optional)

@sftim
Copy link
Contributor

sftim commented Aug 13, 2023

No direct change to docs. Needs review from SIG Release.

@reylejano
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@jeremyrickard
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyrickard, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9d82fca8be730b41f1b611579450cac2d7ed0c06

@Rishit-dagli
Copy link
Member Author

We will merge this tomorrow using write access.

@Rishit-dagli Rishit-dagli changed the base branch from dev-1.28 to main August 15, 2023 19:56
@Rishit-dagli Rishit-dagli removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 700e788 into kubernetes:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@jeremyrickard jeremyrickard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.
5 participants
@Rishit-dagli @sftim @reylejano @jeremyrickard @k8s-ci-robot