ClusterTrustBundles: Add section to certificates page #40065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
language/en
14 tasks
|
/sig auth |
k8s-ci-robot
added
the
sig/auth
|
/assign |
Document the API types as they exist today, plus a hint of the future integrations that will be available.
ahmedtd
force-pushed
the
cluster-trust-bundles
branch
from
ff1d663 to
5cd243d
Compare
k8s-ci-robot
added
size/M
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
liggitt
reviewed
Mar 21, 2023
| {{< feature-state for_k8s_version="v1.27" state="alpha" >}} | ||
|
|
||
| {{< note >}} | ||
| Gated by the `ClusterTrustBundles` feature gate. |
There was a problem hiding this comment.
Suggested change
| Gated by the `ClusterTrustBundles` feature gate. | |
| Use of this feature requires the `ClusterTrustBundle` feature gate to be enabled in `kube-apiserver` and the alpha API to be enabled with `--runtime-config=certificates.k8s.io/v1alpha1/certificatetrustbundles=true`. |
Comment on lines
+474
to
+475
| Future Kubernetes releases will build on them with integrations like the ability | ||
| to project their contents into the pod filesystem. |
There was a problem hiding this comment.
avoid forward looking statements here, just document what exists and is usable today
Comment on lines
+487
to
+488
| rejected during object validation, or filtered by consumers of the object | ||
| (primarily Kubelet). Additionally, consumers will reorder the certificates in |
There was a problem hiding this comment.
Suggested change
| rejected during object validation, or filtered by consumers of the object | |
| (primarily Kubelet). Additionally, consumers will reorder the certificates in | |
| rejected during object validation, or can be ignored by consumers of the object. | |
| Additionally, consumers are allowed to reorder the certificates in |
| the bundle with their own arbitrary but stable ordering. | ||
|
|
||
| ClusterTrustBundle objects should be considered world-readable within the | ||
| cluster. All serviceaccounts have a default RBAC grant to get, list, and watch |
There was a problem hiding this comment.
Suggested change
| cluster. All serviceaccounts have a default RBAC grant to get, list, and watch | |
| cluster. All service accounts have a default RBAC grant to get, list, and watch |
Comment on lines
+522
to
+525
| Signer-linked ClusterTrustBundles will be consumed in workloads by a combination | ||
| of field selector on the signer name and a label selector. If this query | ||
| matches multiple ClusterTrustBundle objects, their contents will be merged, | ||
| deduplicated, and sorted before being provided to the workload. |
There was a problem hiding this comment.
drop the bits referring to projected volumes for now, limit this to documenting the spec.signerName field selector for this release
| metadata: | ||
| name: foo | ||
| spec: | ||
| signerName: "" |
There was a problem hiding this comment.
maybe a comment rather than explicitly setting an empty field?
Suggested change
| signerName: "" | |
| # no signerName specified |
|
@ahmedtd Mind give this another stab? |
|
Closing this PR as the work will be shifted over to #40578. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClusterTrustBundles are a new alpha API type landing in Kubernetes 1.27.