Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified hi.toml to adopt new localization string for release page #38631

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Modified hi.toml to adopt new localization string for release page #38631

merged 2 commits into from
Aug 7, 2023

Conversation

nitishfy
Copy link
Member

@nitishfy nitishfy commented Dec 25, 2022 •
edited
Loading

Fixes:#36760

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language labels Dec 25, 2022
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 25, 2022
@netlify
Copy link

netlify bot commented Dec 25, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 81ab209
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/642d37200e90050008594540
😎 Deploy Preview https://deploy-preview-38631--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

divya-mohan0209
divya-mohan0209 requested changes Jan 2, 2023
View reviewed changes
data/i18n/hi/hi.toml Outdated Show resolved Hide resolved
data/i18n/hi/hi.toml Outdated Show resolved Hide resolved
data/i18n/hi/hi.toml Outdated Show resolved Hide resolved
data/i18n/hi/hi.toml Outdated Show resolved Hide resolved
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 2, 2023
@divya-mohan0209
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 2, 2023
@divya-mohan0209
Copy link
Contributor

@nitishkumar06 : Gentle reminder to address the feedback provided.

divya-mohan0209
divya-mohan0209 previously requested changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit didn't seem to have changed anything. PTAL at the suggestion & amend appropriately.

@nitishfy
Copy link
Member Author

nitishfy commented Apr 5, 2023

PTAL now!

anubha-v-ardhan
anubha-v-ardhan reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fd89a2913308b1b9cc4e64be64abeedf3faf9da3

@Babapool Babapool mentioned this pull request Jun 28, 2023
Closed
Babapool
Babapool reviewed Jun 28, 2023
View reviewed changes
Copy link
Member

@Babapool Babapool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me as well.
/lgtm

@sftim sftim requested a review from divya-mohan0209 July 23, 2023 20:18
@sftim
Copy link
Contributor

sftim commented Jul 23, 2023

Looks OK. I don't speak Hindi.

@divya-mohan0209
Copy link
Contributor

LGTM from me. Approving this for merge.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1d03260 into kubernetes:main Aug 7, 2023
@nitishfy nitishfy deleted the Nitish/hi.toml branch August 7, 2023 15:01
@aj11anuj aj11anuj mentioned this pull request Feb 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubha-v-ardhan anubha-v-ardhan anubha-v-ardhan left review comments

@Babapool Babapool Babapool left review comments

@verma-kunal verma-kunal Awaiting requested review from verma-kunal

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

Assignees

@Babapool Babapool

@anubha-v-ardhan anubha-v-ardhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nitishfy @k8s-triage-robot @divya-mohan0209 @k8s-ci-robot @sftim @Babapool @anubha-v-ardhan