Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate the reference documentation for 1.26 #38336

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Generate the reference documentation for 1.26 #38336

merged 1 commit into from
Dec 10, 2022

Conversation

krol3
Copy link
Contributor

@krol3 krol3 commented Dec 8, 2022 •
edited
Loading

Generate the reference documentation for 1.26, following this step

cc: @divya-mohan0209 @onlydole

@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Dec 8, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 8, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Dec 8, 2022
@netlify
Copy link

netlify bot commented Dec 8, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 8bb9f1a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6393a6abc80ff70009cc57fb

@sftim
Copy link
Contributor

sftim commented Dec 8, 2022 •
edited
Loading

This is missing most of the reference documentation updates. Right now I only see the legacy API reference update - was that what you intended @krol3?

@krol3
Copy link
Contributor Author

krol3 commented Dec 8, 2022

This is missing most of the reference documentation updates. Right now I only see the legacy API reference update - was that what you intended @krol3?

Let me review the instructions again.

@sftim
Copy link
Contributor

sftim commented Dec 8, 2022

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Dec 8, 2022
@tengqm
Copy link
Contributor

tengqm commented Dec 9, 2022

@krol3 There are some updates to the generator, for adapting to changes in 1.26. Please make sure you are using the latest reference-docs generator.

@sftim
Copy link
Contributor

sftim commented Dec 9, 2022

Also see #38350

@nate-double-u
Copy link
Contributor

This needs to target main now.

@krol3 krol3 changed the base branch from dev-1.26 to main December 10, 2022 00:50
@krol3 krol3 changed the base branch from main to dev-1.26 December 10, 2022 00:59
@krol3 krol3 changed the base branch from dev-1.26 to main December 10, 2022 01:23
@krol3
Copy link
Contributor Author

krol3 commented Dec 10, 2022

/unhold

@nate-double-u
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ba23146744d2f0406e7e08cbb1b5dcd040ebba60

@sftim
Copy link
Contributor

sftim commented Dec 10, 2022

/approve

Thanks @krol3

@krol3 krol3 merged commit c9e3c88 into kubernetes:main Dec 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@nate-double-u nate-double-u

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.
5 participants
@krol3 @sftim @tengqm @nate-double-u @k8s-ci-robot