-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix relnotes.k8s.io link #27966
Fix relnotes.k8s.io link #27966
Conversation
It was pointing to `https://kubernetes.io/releases/notes/relnotes.k8s.io`. I'm assuming that adding the scheme will fix it.
Deploy preview for kubernetes-io-master-staging ready! Built with commit b0e4cec https://deploy-preview-27966--kubernetes-io-master-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my final lgtm as I step down from oss.
/lgtm
LGTM label has been added. Git tree hash: ce4e8e69cf94607169142b70f4959fd9966efcc9
|
Thanks for the catch and quick fix! Thanks @markyjackson-taulia - hopefully not the final forever! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimangel, markyjackson-taulia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It was pointing to
https://kubernetes.io/releases/notes/relnotes.k8s.io
. I'm assuming that adding the scheme will fix it./assign @jimangel