Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Priority and Preemption to Scheduling section #27947

Merged
merged 1 commit into from
May 11, 2021
Merged

Move Priority and Preemption to Scheduling section #27947

merged 1 commit into from
May 11, 2021

Conversation

shannonxtreme
Copy link
Contributor

Fixes #27938

Changes

  • Moved Pod Priority and Preemption under Scheduling and Eviction
  • Renamed Scheduling and Eviction to Scheduling, Preemption and Eviction (but kept the URL the same)
  • Redirects

Notes

@sftim - do we need to rearrange the order of sections under Scheduling, Preemption and Eviction?

Maybe:

  1. Kubernetes Scheduler
  2. Taints and Tolerations
  3. Assigning Pods to Nodes
  4. Pod Priority and Preemption
  5. Pod Overhead
  6. Eviction
  7. Scheduling framework
  8. Scheduler performance tuning

/sig docs
/assign

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 11, 2021
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 11, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2021
@shannonxtreme
Copy link
Contributor Author

cc @alculquicondor

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c2a149b609482971da3d2e9a1d806f0ebaf6c68c

@netlify
Copy link

netlify bot commented May 11, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 38d1e02

https://deploy-preview-27947--kubernetes-io-master-staging.netlify.app

@netlify
Copy link

netlify bot commented May 11, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8b0f264

https://deploy-preview-27947--kubernetes-io-master-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented May 11, 2021

rearrange the order of sections under Scheduling, Preemption and Eviction?

Feel free! The weight field in page front matter controls ordering. I'd make the ordering changes happen in their own commit.

@sftim
Copy link
Contributor

sftim commented May 11, 2021

I'm going to approve this as-is; we can reorder pages in a follow up PR.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit e751578 into kubernetes:master May 11, 2021
@shannonxtreme shannonxtreme deleted the priority-move branch June 4, 2021 15:39
@t-inu t-inu mentioned this pull request Apr 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

Assignees

@alculquicondor alculquicondor

@shannonxtreme shannonxtreme

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Pod Priority and Preemption under Scheduling and Eviction
4 participants
@shannonxtreme @alculquicondor @k8s-ci-robot @sftim