Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link PVC volume mode and access mode sections to corresponding sections in PV #27912

Merged
merged 1 commit into from
May 10, 2021

Conversation

verult
Copy link
Contributor

@verult verult commented May 8, 2021

/cc @msau42

@k8s-ci-robot k8s-ci-robot requested a review from msau42 May 8, 2021 02:13
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 8, 2021
@verult
Copy link
Contributor Author

verult commented May 8, 2021

/assign @PI-Victor

@netlify
Copy link

netlify bot commented May 8, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3976df3

https://deploy-preview-27912--kubernetes-io-master-staging.netlify.app

@PI-Victor PI-Victor removed their assignment May 8, 2021
@sftim
Copy link
Contributor

sftim commented May 10, 2021

/lgtm
Thanks
/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label May 10, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2b090939a40164ff9e9a7c765f86bb6de3e5c229

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An idea for extra tidying (optional)

@@ -540,11 +540,11 @@ spec:

### Access Modes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Access Modes
### Access Modes {#access-mode-pvc}

will set a custom fragment identifier

@@ -540,11 +540,11 @@ spec:

### Access Modes

Claims use the same conventions as volumes when requesting storage with specific access modes.
Claims use [the same conventions as volumes](#access-modes) when requesting storage with specific access modes.

### Volume Modes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Volume Modes
### Volume Modes {#volume-mode-pvc}

will set a custom fragment identifier (avoiding potential for a collision / confusion)

@verult
Copy link
Contributor Author

verult commented May 10, 2021

This section is linked in k8s API references using the current URL, so while it's cleaner with a more explicit name, we'd need to update API reference doc as well, and it may break other existing links. So I'll keep the header as is.

@sftim would you be able to approve as well? Thanks in advance!

@sftim
Copy link
Contributor

sftim commented May 10, 2021

I'll keep the header as is.

OK, fair enough.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 44d85c5 into kubernetes:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants