-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link PVC volume mode and access mode sections to corresponding sections in PV #27912
Link PVC volume mode and access mode sections to corresponding sections in PV #27912
Conversation
/assign @PI-Victor |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 3976df3 https://deploy-preview-27912--kubernetes-io-master-staging.netlify.app |
/lgtm |
LGTM label has been added. Git tree hash: 2b090939a40164ff9e9a7c765f86bb6de3e5c229
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An idea for extra tidying (optional)
@@ -540,11 +540,11 @@ spec: | |||
|
|||
### Access Modes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Access Modes | |
### Access Modes {#access-mode-pvc} |
will set a custom fragment identifier
@@ -540,11 +540,11 @@ spec: | |||
|
|||
### Access Modes | |||
|
|||
Claims use the same conventions as volumes when requesting storage with specific access modes. | |||
Claims use [the same conventions as volumes](#access-modes) when requesting storage with specific access modes. | |||
|
|||
### Volume Modes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Volume Modes | |
### Volume Modes {#volume-mode-pvc} |
will set a custom fragment identifier (avoiding potential for a collision / confusion)
This section is linked in k8s API references using the current URL, so while it's cleaner with a more explicit name, we'd need to update API reference doc as well, and it may break other existing links. So I'll keep the header as is. @sftim would you be able to approve as well? Thanks in advance! |
OK, fair enough. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @msau42