Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix example for customizing the control plane with scheduler flags #27900

Merged
merged 1 commit into from
May 11, 2021
Merged

fix example for customizing the control plane with scheduler flags #27900

merged 1 commit into from
May 11, 2021
+7 −3

Conversation

wangyysde
Copy link
Member

Signed-off-by: wangyysde net_use@bzhy.com

The example at https://github.com/kubernetes/website/blob/master/content/en/docs/setup/production-environment/tools/kubeadm/control-plane-flags.md#scheduler-flags shows scheduler.extraArgs.config in the ClusterConfiguration being used without scheduler.extraVolumes. But kubeadm sets up the scheduler to run inside a pod, it is necessary to use scheduler.extraVolumes to mount the config file into the pod.
kubeconfig in the original example is simillar to config. If we keep this item in the sample, we should add more lines into the extraVolumes section. For the sake of simplicity, I use feature-gates instead of kubeconfig.

Fix: #27816

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2021
@k8s-ci-robot k8s-ci-robot requested review from jimangel and onlydole May 7, 2021 09:18
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2021
@netlify
Copy link

netlify bot commented May 7, 2021 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c7ed3bc

https://deploy-preview-27900--kubernetes-io-master-staging.netlify.app

@neolit123
Copy link
Member

/sig cluster-lifecycle
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 10, 2021
neolit123
neolit123 reviewed May 11, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flags.md change looks good. But there is also a api-ref-generator change in the diff. Not sure why is that?

@wangyysde
fix example for customizing the control plane with scheduler flags
c7ed3bc 
Signed-off-by: wangyysde <net_use@bzhy.com>
@wangyysde
Copy link
Member Author

Thanks. Maybe that is that I have built and run wesite with make container-image and make container-serve commands in website root directory. Now I have cloned the website from github and redone it. Could you review it again? Thanks.

@neolit123
Copy link
Member

thank you
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 850d7f448965bf6e8496d98fa6e8c79ede6470b0

savitharaghunathan
savitharaghunathan reviewed May 11, 2021
View reviewed changes
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitharaghunathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 36f5cd1 into kubernetes:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitharaghunathan savitharaghunathan savitharaghunathan left review comments

@neolit123 neolit123 neolit123 left review comments

@jimangel jimangel Awaiting requested review from jimangel

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
4 participants
@wangyysde @neolit123 @k8s-ci-robot @savitharaghunathan