Update note for waitForFirstConsumer binding mode with example #27884
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
language/en
|
/assign @msau42 |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit e7d3e27 https://deploy-preview-27884--kubernetes-io-master-staging.netlify.app |
| @@ -156,7 +156,7 @@ the class or PV. If a mount option is invalid, the PV mount fails. | |||
| The `volumeBindingMode` field controls when [volume binding and dynamic | |||
| provisioning](/docs/concepts/storage/persistent-volumes/#provisioning) should occur. | |||
|
|
|||
| By default, the `Immediate` mode indicates that volume binding and dynamic | |||
| The `Immediate` mode indicates that volume binding and dynamic | |||
There was a problem hiding this comment.
I think it's still good to say that Immediate is the default behavior
There was a problem hiding this comment.
ok, right without specifying any mode, the default is "Immediate"
| @@ -188,6 +188,43 @@ The following plugins support `WaitForFirstConsumer` with pre-created Persistent | |||
| and pre-created PVs, but you'll need to look at the documentation for a specific CSI driver | |||
| to see its supported topology keys and examples. | |||
|
|
|||
| :::note | |||
| If you choose to use `waitForFirstConsumer` in storage classes, do not use `nodeName` in the Pod spec | |||
There was a problem hiding this comment.
How about something like
If you choose to use `WaitForFirstConsumer`, do not use...
| @@ -188,6 +188,43 @@ The following plugins support `WaitForFirstConsumer` with pre-created Persistent | |||
| and pre-created PVs, but you'll need to look at the documentation for a specific CSI driver | |||
| to see its supported topology keys and examples. | |||
|
|
|||
| :::note | |||
| If you choose to use `waitForFirstConsumer` in storage classes, do not use `nodeName` in the Pod spec | |||
| to specify node affinity. If `nodeName` is used in this case, then PVC will remain in `pending` state. For more details refer https://github.com/openebs/openebs/issues/2915. | |||
There was a problem hiding this comment.
I don't think we should refer to issues outside of the kubernetes repo. Maybe just say something like the scheduler will be bypassed and the PVC will remain...
| metadata: | ||
| name: task-pv-pod | ||
| spec: | ||
| affinity: |
There was a problem hiding this comment.
It could be even simpler than this if you use nodeSelector
Update binding mode related to nodeName
|
updated, PTAL @msau42 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6c650a0c37b2951847be83748eb10f6dc00e96fb
|
|
/assign @reylejano |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitharaghunathan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Update binding mode related to nodeName and give an example