Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] Resync kubeadm files (1) #27720

Merged
merged 1 commit into from
Apr 29, 2021
Merged

[zh] Resync kubeadm files (1) #27720

merged 1 commit into from
Apr 29, 2021

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Apr 26, 2021

related: #27670

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 26, 2021
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 26, 2021
@tengqm tengqm mentioned this pull request Apr 26, 2021
Closed
@netlify
Copy link

netlify bot commented Apr 26, 2021 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c4438bd

https://deploy-preview-27720--kubernetes-io-master-staging.netlify.app

SataQiu
SataQiu reviewed Apr 26, 2021
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tengqm ！
LGTM, other than some nits.

content/zh/docs/reference/config-api/kubelet-config.v1beta1.md Show resolved Hide resolved
content/zh/docs/setup/production-environment/tools/kubeadm/high-availability.md Outdated Show resolved Hide resolved
content/zh/docs/setup/production-environment/tools/kubeadm/high-availability.md Outdated Show resolved Hide resolved
content/zh/docs/setup/production-environment/tools/kubeadm/high-availability.md Outdated Show resolved Hide resolved
content/zh/docs/setup/production-environment/tools/kubeadm/kubelet-integration.md Outdated Show resolved Hide resolved
@tengqm tengqm force-pushed the zh-sync-kubeadm-1 branch from 7b68050 to c4438bd Compare April 27, 2021 03:07
SataQiu
SataQiu reviewed Apr 29, 2021
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 985b722cca4e80d2014bf00630c98ed244dde94a

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6be4218 into kubernetes:master Apr 29, 2021
@tengqm tengqm deleted the zh-sync-kubeadm-1 branch April 29, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu SataQiu left review comments

@idealhack idealhack Awaiting requested review from idealhack

Assignees

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tengqm @k8s-ci-robot @SataQiu