Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified the output when retrieving Secrets. #27424

Merged
merged 1 commit into from
May 10, 2021
Merged

Modified the output when retrieving Secrets. #27424

merged 1 commit into from
May 10, 2021

Conversation

Shubham82
Copy link
Contributor

Modified the output when we retrieving the secrets through kubectl get secrets <secrets_name> -o yaml in Managing Secret using Configuration File
When we run this command the data field should show after apiversion.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 6, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2021
@Shubham82
Copy link
Contributor Author

Hi @bradtopol @onlydole
Could please take a look.

@netlify
Copy link

netlify bot commented Apr 6, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2b822af

https://deploy-preview-27424--kubernetes-io-master-staging.netlify.app

@kbhawkey
Copy link
Contributor

Hello @Shubham82 .
Thanks for your contribution.
The changes look okay. I'm not convinced that the changes are required, though.

Page preview:
https://deploy-preview-27424--kubernetes-io-master-staging.netlify.app/docs/tasks/configmap-secret/managing-secret-using-config-file/

@Shubham82
Copy link
Contributor Author

Hi @kbhawkey
My only concern it should look same when we get the Secrets like it did in another secrets examples, to maintain the uniformity of the documents.

@kbhawkey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1abf829c24001a2eaad91b8a2f5ee9c380c1eee9

@Shubham82
Copy link
Contributor Author

Hi @sftim
Could please take a look!

savitharaghunathan
savitharaghunathan reviewed May 10, 2021
View reviewed changes
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitharaghunathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 98ae77b into kubernetes:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitharaghunathan savitharaghunathan savitharaghunathan left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@kbhawkey kbhawkey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shubham82 @kbhawkey @k8s-ci-robot @savitharaghunathan