Move portuguese content to pt-br to correct shortcode problems and add redirection #27413

rikatz · 2021-04-05T17:17:20Z

After Hugo 0.76 the i18n Go library has been migrated, breaking languages like portuguese in some parts (as it requires the full locale like pt-br instead of only pt).

This PR migrates the Portuguese translation to pt-br and adds a redirect in netlify to users that might have bookmarked the documentation in portuguese to be redirected to /pt-br/

…d a redirection

rikatz · 2021-04-05T17:25:09Z

/assign @sftim

As we spoke. I'm waiting for the preview to be generated so we can see if this works :D

netlify · 2021-04-05T17:31:17Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4f134c4

https://deploy-preview-27413--kubernetes-io-master-staging.netlify.app

netlify · 2021-04-05T17:35:51Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4c42fa2

https://deploy-preview-27413--kubernetes-io-master-staging.netlify.app

jailton · 2021-04-06T13:17:23Z

@rikatz thanks!

/lgtm

k8s-ci-robot · 2021-04-06T13:17:36Z

LGTM label has been added.

Git tree hash: 27c7f27bbad3d61a05f207abc6f62405c69144eb

sftim

A couple of minor things.

static/_redirects

i18n/pt-br.toml

…d a redirection

rikatz · 2021-04-06T23:09:02Z

/label tide/merge-method-squash

@sftim everything corrected here :)

kbhawkey · 2021-04-06T23:43:53Z

I am happy to see the site build warning errors removed. I will review the changes.
I suggest waiting to merge this PR until the 1.21 release is complete.
/hold

kbhawkey · 2021-04-06T23:57:02Z

Hi @rikatz ,
Do you think the name of the language in the language dropdown list should change (Portuguese Brazil)?
Is the "print entire section" string translated in the docsy theme (pt-br)?

Page previews:
https://deploy-preview-27413--kubernetes-io-master-staging.netlify.app/pt-br/

https://deploy-preview-27413--kubernetes-io-master-staging.netlify.app/pt-br/blog/

Note: The image is missing from the community page?
https://deploy-preview-27413--kubernetes-io-master-staging.netlify.app/pt-br/community/

Note: I saw a warning about the URL?
https://deploy-preview-27413--kubernetes-io-master-staging.netlify.app/pt-br/partners/#kcsp

https://deploy-preview-27413--kubernetes-io-master-staging.netlify.app/pt-br/docs/concepts/containers/images/

rikatz · 2021-04-07T12:00:33Z

Hey @kbhawkey thanks for the double checking and getting those problems.

Is the "print entire section" string translated in the docsy theme (pt-br)?

The string exists in docsy theme (themes/docsy/i18n/pt-br.toml) but it's not translated for any language.

Those are the new short codes, probably other localizations would want to translate them as well. I've added them to i18n/pt-br.toml just to make it work, but if you think it's better I can open the PR directly to docsy repo :)

[post_create_issue]
[print_click_to_print]
[print_entire_section]
[print_printable_section]
[print_show_regular]

Do you think the name of the language in the language dropdown list should change (Portuguese Brazil)?

I have no strong opinion on this. I guess as soon as no one wants to translate to Portuguese from Portugal, we can keep the dropdown item as is, and then it's only simple change in config.toml if we decide for something different later.

The image is missing from the community page?
Actually it seems the community page is a static html and not a markdown :D (_index.html). Anyway, I guess we can open a followup issue/PR and ask for someone to take a look (will do now in Slack) (@jailton @devlware @Jesus fyi)

EDIT: Issue opened: #27446

About the warnings - I've ran hugo serve -F --i18n-warnings and regarding portuguese I only saw:

i18n|MISSING_TRANSLATION|pt-BR|main_kubeweekly_past_link

Which seems to be a shortcode not translated yet in any other language :D Can do a followup as well (as @sftim asked me to keep this PR related to the location movement).

So:

I've added the missing print shortcodes (the last separated commit)
Moved the content to a location where we don't have a lot of warnings anymore and shortcodes get translated

I'm more than ok (and I think it's actually right!) to wait until the doc freeze ends and v1.21 gets released 🥳

kbhawkey · 2021-04-10T02:26:02Z

/hold cancel

rikatz · 2021-04-15T12:23:11Z

Hey @kbhawkey @sftim can we move forward with this one?

Thanks!!

rikatz · 2021-04-19T20:00:12Z

Adding some comments here about the safeness of this PR:

Hugo and docsy already look into pt-br location (instead of only pt). While the only translation variation existent in k/docs nowadays is Brazilian Portuguese, doing this will allow some future work if someone wants to other Portuguese variations
To help people that has already bookmarked docs/pt, we've added some redirections in this case.
The language menu list wasn't changed as we are already being the 'Portuguese' translation existent, but changing this in a future is a no impact

kbhawkey · 2021-04-19T23:35:04Z

/approve

k8s-ci-robot · 2021-04-19T23:35:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kbhawkey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jailton · 2021-04-20T00:09:05Z

/lgtm

k8s-ci-robot · 2021-04-20T00:09:15Z

LGTM label has been added.

Git tree hash: 373291e94579270af4565dc5a4ec0400f09dce84

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 5, 2021

k8s-ci-robot requested review from celestehorgan and kbhawkey April 5, 2021 17:18

k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 5, 2021

Move portuguese content to pt-br to correct shortcode problems and ad…

7214220

…d a redirection

rikatz force-pushed the move-pt-location branch from c0ffaa5 to 7214220 Compare April 5, 2021 17:23

k8s-ci-robot assigned sftim Apr 5, 2021

Correct small shortcode

99e2516

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2021

k8s-ci-robot assigned jailton Apr 6, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2021

sftim reviewed Apr 6, 2021

View reviewed changes

static/_redirects Outdated Show resolved Hide resolved

i18n/pt-br.toml Outdated Show resolved Hide resolved

Move portuguese content to pt-br to correct shortcode problems and ad…

ffb1440

…d a redirection

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2021

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 6, 2021

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2021

Add missing print page shortcodes

4c42fa2

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2021

rikatz mentioned this pull request Apr 15, 2021

Allow localization teams to review their own strings #27408

Merged

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2021

k8s-ci-robot merged commit ae19769 into kubernetes:master Apr 20, 2021

stormqueen1990 mentioned this pull request Nov 23, 2022

[pt-br] Move Portuguese localization files to pt-br folder #37967

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move portuguese content to pt-br to correct shortcode problems and add redirection #27413

Move portuguese content to pt-br to correct shortcode problems and add redirection #27413

rikatz commented Apr 5, 2021

rikatz commented Apr 5, 2021

netlify bot commented Apr 5, 2021

netlify bot commented Apr 5, 2021 •

edited

Loading

jailton commented Apr 6, 2021

k8s-ci-robot commented Apr 6, 2021

sftim left a comment

rikatz commented Apr 6, 2021

kbhawkey commented Apr 6, 2021

kbhawkey commented Apr 6, 2021

rikatz commented Apr 7, 2021 •

edited

Loading

kbhawkey commented Apr 10, 2021

rikatz commented Apr 15, 2021

rikatz commented Apr 19, 2021

kbhawkey commented Apr 19, 2021

k8s-ci-robot commented Apr 19, 2021

jailton commented Apr 20, 2021

k8s-ci-robot commented Apr 20, 2021

Move portuguese content to pt-br to correct shortcode problems and add redirection #27413

Move portuguese content to pt-br to correct shortcode problems and add redirection #27413

Conversation

rikatz commented Apr 5, 2021

rikatz commented Apr 5, 2021

netlify bot commented Apr 5, 2021

netlify bot commented Apr 5, 2021 • edited Loading

jailton commented Apr 6, 2021

k8s-ci-robot commented Apr 6, 2021

sftim left a comment

Choose a reason for hiding this comment

rikatz commented Apr 6, 2021

kbhawkey commented Apr 6, 2021

kbhawkey commented Apr 6, 2021

rikatz commented Apr 7, 2021 • edited Loading

kbhawkey commented Apr 10, 2021

rikatz commented Apr 15, 2021

rikatz commented Apr 19, 2021

kbhawkey commented Apr 19, 2021

k8s-ci-robot commented Apr 19, 2021

jailton commented Apr 20, 2021

k8s-ci-robot commented Apr 20, 2021

netlify bot commented Apr 5, 2021 •

edited

Loading

rikatz commented Apr 7, 2021 •

edited

Loading