Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote VolumeSubpathEnvExpansion to GA #16547

Merged
merged 1 commit into from
Nov 2, 2019
Merged

Promote VolumeSubpathEnvExpansion to GA #16547

merged 1 commit into from
Nov 2, 2019

Conversation

kevtaylor
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 25, 2019
@sftim
Copy link
Contributor

sftim commented Sep 25, 2019

In terms of “is this valid Markdown” and “is this a reasonable change to propose for the next release branch”:
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2019
@kevtaylor kevtaylor mentioned this pull request Oct 2, 2019
Closed
@zacharysarah
Copy link
Contributor

/milestone 1.17

@k8s-ci-robot k8s-ci-robot added this to the 1.17 milestone Oct 8, 2019
@kevtaylor
Copy link
Contributor Author

Code is now merged at kubernetes/kubernetes#82578 so this is good to go

@daminisatya
Copy link
Contributor

@kevtaylor Can you resolve the conflicts, please? Once done it is good to go.

@kevtaylor kevtaylor force-pushed the kep/VolumeSubpathEnvExpansion-GA branch from 4a43e0b to 0e57086 Compare November 2, 2019 07:52
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 0e57086

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5dbd35b19c26200007b15963

@kevtaylor
Copy link
Contributor Author

@daminisatya Should be okay now

@daminisatya
Copy link
Contributor

@kevtaylor Awesome! Thank you so much for the quick fix.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2019
@daminisatya
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daminisatya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4442fd0 into kubernetes:dev-1.17 Nov 2, 2019
@sftim sftim mentioned this pull request Nov 14, 2019
Merged
@guineveresaenger
Copy link

/check cla

@guineveresaenger
Copy link

ugh

/check-cla

kbhawkey added a commit to kbhawkey/website that referenced this pull request Dec 4, 2019
@kbhawkey
Revert "Promote VolumeSubpathEnvExpansion to GA (kubernetes#16547)"
ea88902 
This reverts commit 4442fd0.
k8s-ci-robot pushed a commit that referenced this pull request Dec 6, 2019
@kbhawkey @k8s-ci-robot
Revert "Promote VolumeSubpathEnvExpansion to GA (#16547)" (#17946)
6e99b11 
This reverts commit 4442fd0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

Assignees

@daminisatya daminisatya

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.
7 participants
@kevtaylor @sftim @zacharysarah @daminisatya @k8sio-netlify-preview-bot @k8s-ci-robot @guineveresaenger