Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with /docs/admin/admission-controllers/ #3588

Closed
1 of 2 tasks
praving55 opened this issue Apr 30, 2017 · 7 comments
Closed
1 of 2 tasks

Issue with /docs/admin/admission-controllers/ #3588

praving55 opened this issue Apr 30, 2017 · 7 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@praving55
Copy link

This is a...

  • Feature Request
  • Bug Report

Problem:
Missing Documentation for all admission controllers. Below is the current list of admission controllers

AlwaysAdmit
AlwaysDeny
AlwaysPullImages
DefaultStorageClass
DefaultTolerationSeconds
DenyEscalatingExec
DenyExecOnPrivileged
ImagePolicyWebhook
InitialResources
LimitPodHardAntiAffinityTopology
LimitRanger
NamespaceAutoProvision
NamespaceExists
NamespaceLifecycle
OwnerReferencesPermissionEnforcement
PersistentVolumeLabel
PodNodeSelector
PodPreset
PodSecurityPolicy
ResourceQuota
SecurityContextDeny
ServiceAccount

However, the current documentation explaining each of them has information only for

AlwaysAdmit
AlwaysPullImages
AlwaysDeny
DenyEscalatingExec
ImagePolicyWebhook
Configuration File Format
Request Payloads
Extending with Annotations
ServiceAccount
SecurityContextDeny
ResourceQuota
LimitRanger
InitialResources (experimental)
NamespaceLifecycle
DefaultStorageClass
DefaultTolerationSeconds
PodSecurityPolicy

Proposed Solution:
Take some time to document

Page to Update:
https://kubernetes.io/docs/admin/admission-controllers/
@ahmetb
Copy link
Member

ahmetb commented May 1, 2017

@praving55 Thanks for reporting. If you have time, contributions are welcome.

@jaredbhatti
Copy link
Contributor

Appears that the following are missing:

DefaultStorageClass
DefaultTolerationSeconds
InitialResources
LimitPodHardAntiAffinityTopology
LimitRanger
NamespaceAutoProvision
NamespaceExists
OwnerReferencesPermissionEnforcement
PersistentVolumeLabel
PodNodeSelector
PodPreset

Also, we should reorganize this page into alphabetical order.

@liggitt liggitt mentioned this issue Sep 5, 2017
Merged
@caesarxuchao
Copy link
Member

caesarxuchao commented Sep 5, 2017 •
edited
Loading

I'm assigning myself for the OwnerReferencesPermissionEnforcement, Initializer,
GenericAdmissionWebhook.

/assign @caesarxuchao

@ahmetb
Copy link
Member

ahmetb commented Sep 5, 2017

The following are missing, too:

Initializer
GenericAdmissionWebhook

@caesarxuchao
Copy link
Member

#4751 is addressing the issue.

@caesarxuchao caesarxuchao removed their assignment Sep 6, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2018
@tengqm
Copy link
Contributor

tengqm commented Jan 5, 2018

I believe all admission controllers are documented now. Please reopen if this is not true.

@tengqm tengqm closed this as completed Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ahmetb @caesarxuchao @tengqm @jaredbhatti @k8s-ci-robot @praving55 @fejta-bot