Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n changes approvable by sig-localization teams #26921

Closed
raelga opened this issue Mar 6, 2021 · 6 comments · Fixed by #27408
Closed

i18n changes approvable by sig-localization teams #26921

raelga opened this issue Mar 6, 2021 · 6 comments · Fixed by #27408
Assignees
@raelga @sftim
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@raelga
Copy link
Member

raelga commented Mar 6, 2021 •
edited
Loading

What would you like to be added

Currently, i18n files live under /i18n at the root folder and only sig-docs-en-owners can approve those files. Under the i18n folder resides the toml files containing localised strings for each language used across the site. It would be nice to add some mechanism to enable sig-docs-localisation approvers permission to approve changes on their language toml files.

Why is this needed

This will enable better handling of the i18n language files as will be owned by the corresponding localization team and instead of failing to the sig-docs-en team.

Comments

This was discussed on the last sig-docs and sig-docs-localization meetings.

/area web-development
/kind feature
/sig docs
/language en
/language es
@raelga raelga self-assigned this Mar 6, 2021
@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. sig/docs Categorizes an issue or PR as relevant to SIG Docs. language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 6, 2021
@raelga
Copy link
Member Author

raelga commented Mar 6, 2021

/cc @sftim
/cc @bradtopol
/cc @seokho-son
/language ko

@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Mar 6, 2021
@sftim
Copy link
Contributor

sftim commented Mar 6, 2021

/triage accepted
/assign

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 6, 2021
@sftim
Copy link
Contributor

sftim commented Mar 6, 2021

/remove-language en
/remove-language ko
/remove-language es
as this would be a generic mechanism

@k8s-ci-robot k8s-ci-robot removed language/en Issues or PRs related to English language language/ko Issues or PRs related to Korean language language/es Issues or PRs related to Spanish language labels Mar 6, 2021
@sftim
Copy link
Contributor

sftim commented Mar 6, 2021

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 6, 2021
@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 6, 2021

This seems like a good idea.

@sftim sftim mentioned this issue Apr 5, 2021
Merged
@sftim
Copy link
Contributor

sftim commented Apr 5, 2021

If #27408 merges, we can additionally configure blockades (a Prow plugin) to restrict who is able to change the original i18n directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raelga raelga

@sftim sftim

Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow localization teams to review their own strings sftim/kubernetes-website
4 participants
@raelga @kbhawkey @k8s-ci-robot @sftim