Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional presubmits for scale-testing on GCE-100/500/2000 clusters #7168

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Add optional presubmits for scale-testing on GCE-100/500/2000 clusters #7168

merged 1 commit into from
Mar 7, 2018

Conversation

shyamjvs
Copy link
Member

@shyamjvs shyamjvs commented Mar 7, 2018

Implements phase-1 (part) of the proposed formal scalability processes.

/cc @wojtek-t @kubernetes/sig-scalability-misc
fyi - @krzyzacy @BenTheElder

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 7, 2018
@shyamjvs shyamjvs requested a review from wojtek-t March 7, 2018 17:20
@shyamjvs shyamjvs mentioned this pull request Mar 7, 2018
Closed
@krzyzacy
Copy link
Member

krzyzacy commented Mar 7, 2018

looks like you are missing --stage flag in config.json :-)

@shyamjvs shyamjvs force-pushed the add-gce-optional-presubmit-jobs branch from 1bedd61 to 7cf0f41 Compare March 7, 2018 18:15
@shyamjvs
Copy link
Member Author

shyamjvs commented Mar 7, 2018

Fixed it hopefully.

@BenTheElder
Copy link
Member

security repo is out of sync, hack/update-config.sh will correct it.

@shyamjvs shyamjvs force-pushed the add-gce-optional-presubmit-jobs branch from 7cf0f41 to ac6980c Compare March 7, 2018 18:28
@shyamjvs
Copy link
Member Author

shyamjvs commented Mar 7, 2018

Done.

@krzyzacy
Copy link
Member

krzyzacy commented Mar 7, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, shyamjvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 991846a into kubernetes:master Mar 7, 2018
@k8s-ci-robot
Copy link
Contributor

@shyamjvs: Updated the config configmap

In response to this:

Implements phase-1 (part) of the proposed formal scalability processes.

/cc @wojtek-t @kubernetes/sig-scalability-misc
fyi - @krzyzacy @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shyamjvs shyamjvs deleted the add-gce-optional-presubmit-jobs branch March 7, 2018 18:44
@shyamjvs shyamjvs mentioned this pull request Mar 8, 2018
Merged
@shyamjvs
Copy link
Member Author

shyamjvs commented Apr 4, 2018

Ref umbrella - #4445

@shyamjvs
Copy link
Member Author

shyamjvs commented Apr 4, 2018

Ref umbrella - #5677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@michelle192837 michelle192837 Awaiting requested review from michelle192837

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shyamjvs @krzyzacy @BenTheElder @k8s-ci-robot