Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install bc in kubekins-e2e and bump images #7095

Merged
merged 3 commits into from
Mar 2, 2018
Merged

install bc in kubekins-e2e and bump images #7095

merged 3 commits into from
Mar 2, 2018

Conversation

BenTheElder
Copy link
Member

apparently shell2junit needs bc
/shrug

@BenTheElder BenTheElder requested a review from krzyzacy as a code owner March 2, 2018 04:56
@k8s-ci-robot k8s-ci-robot added ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 2, 2018
@BenTheElder
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 2, 2018
@BenTheElder
Copy link
Member Author

/assign @krzyzacy
/cc @rmmh

@k8s-ci-robot k8s-ci-robot requested a review from rmmh March 2, 2018 04:59
@BenTheElder
Copy link
Member Author

BenTheElder commented Mar 2, 2018 •
edited
Loading

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-canary/12574/?log#log
green run with the new image
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2018
@krzyzacy
Copy link
Member

krzyzacy commented Mar 2, 2018

for which job?

@BenTheElder
Copy link
Member Author

@krzyzacy typecheck

@krzyzacy
Copy link
Member

krzyzacy commented Mar 2, 2018

/shrug
time to add all kubekins-test dependency and just unify everything to kubekins-e2e?
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

@krzyzacy maybe. kubekins-e2e is definitely bloated, I don't think this will make or break it though
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit 7bc9015 into kubernetes:master Mar 2, 2018
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the config configmap

In response to this:

apparently shell2junit needs bc
/shrug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the bash-whee branch March 2, 2018 06:47
@krzyzacy krzyzacy mentioned this pull request Mar 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@rmmh rmmh Awaiting requested review from rmmh

Assignees

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @krzyzacy @k8s-ci-robot