Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go1.9.2 and bazel 0.8.1 in kubekins-e2e for k8s 1.9+ #5990

Merged
merged 3 commits into from
Dec 18, 2017
Merged

Use go1.9.2 and bazel 0.8.1 in kubekins-e2e for k8s 1.9+ #5990

merged 3 commits into from
Dec 18, 2017

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Dec 15, 2017

Forgot to include this in #5961.

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 15, 2017
ixdy referenced this pull request Dec 15, 2017
@BenTheElder
log image name:tag when running bootstrap jobs
e67937d
BenTheElder
BenTheElder approved these changes Dec 15, 2017
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, ixdy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

#5991 should go first and then fix up this one

@ixdy ixdy force-pushed the kubekins-e2e-bazel-bump branch from 7af2ea0 to 8f0a611 Compare December 15, 2017 23:00
@ixdy
Copy link
Member Author

ixdy commented Dec 15, 2017

Rebased and repushed.

Might be too late today to merge this, though.

@ixdy ixdy mentioned this pull request Dec 16, 2017
Merged
@BenTheElder
Copy link
Member

needs rebase now as well 🤷‍♂️

@ixdy ixdy force-pushed the kubekins-e2e-bazel-bump branch from 8f0a611 to 0c7b8c7 Compare December 18, 2017 19:05
@ixdy
Copy link
Member Author

ixdy commented Dec 18, 2017

Rebased, rebuilt, repushed. This should be good to go, I think?

@BenTheElder
Copy link
Member

/shrug

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Dec 18, 2017
@ixdy
Copy link
Member Author

ixdy commented Dec 18, 2017

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2017
@k8s-ci-robot k8s-ci-robot merged commit b6d1b41 into kubernetes:master Dec 18, 2017
@k8s-ci-robot
Copy link
Contributor

@ixdy: I updated Prow config for you!

In response to this:

Forgot to include this in #5961.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ixdy ixdy deleted the kubekins-e2e-bazel-bump branch December 18, 2017 19:20
@ixdy
Copy link
Member Author

ixdy commented Dec 18, 2017

Argh, this broke pull-kubernetes-kubemark-e2e-gce, pull-kubernetes-e2e-kops-aws, and pull-kubernetes-e2e-gce-device-plugin-gpu on everything older than 1.9, since those jobs are now using bazel, but we haven't branchified the prow configs.

@ixdy ixdy mentioned this pull request Dec 18, 2017
Closed
This was referenced Dec 18, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ixdy @k8s-ci-robot @BenTheElder