Pass FEDERATION=true before building tarball in federation e2e #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thanks @nikhiljindal |
ghost
self-assigned this
ghost
added
the
lgtm
ghost
merged commit
ostromart
pushed a commit
to ostromart/test-infra
that referenced
this pull request
Jul 26, 2019
Automatic merge from submit-queue Add kubeconfig for mixer/presubmit **Release note**: ```release-note None ```
grantr
pushed a commit
to grantr/test-infra
that referenced
this pull request
Feb 21, 2020
They break the authentication if present.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref kubernetes/kubernetes#30458 kubernetes/kubernetes#26723
Moving the federation params to the top so that they are set when running any command (particularly
./hack/jenkins/build.shright now).Also removed KUBE_GCS_RELEASE_BUCKET and KUBE_GCS_DEV_RELEASE_BUCKET which are not used since we are setting KUBE_SKIP_PUSH_GCS=y.
cc @ixdy @colhom @quinton-hoole