Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: add e2e test for kubelet instance config #33807

Merged
merged 1 commit into from
Dec 16, 2024
Merged

kubeadm: add e2e test for kubelet instance config #33807

merged 1 commit into from
Dec 16, 2024

Conversation

HirazawaUi
Copy link
Contributor

@HirazawaUi HirazawaUi commented Nov 18, 2024 •
edited
Loading

Add e2e test for kubelet instance config.

relate: kubernetes/kubeadm#3126

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2024
@k8s-ci-robot k8s-ci-robot requested a review from dims November 18, 2024 14:16
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 18, 2024
@HirazawaUi HirazawaUi mentioned this pull request Nov 18, 2024
Merged
@HirazawaUi HirazawaUi force-pushed the add-instance-config-tests branch from b6d2e37 to 5df7e5b Compare November 18, 2024 14:28
@HirazawaUi
Copy link
Contributor Author

/cc @neolit123

@HirazawaUi HirazawaUi force-pushed the add-instance-config-tests branch from 5df7e5b to 5e7d3d9 Compare November 28, 2024 13:55
neolit123
neolit123 reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
please check if it runs here
https://testgrid.k8s.io/sig-cluster-lifecycle-kubeadm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2024
@neolit123
Copy link
Member

/hold
kubernetes/kubeadm#3126 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2024
@neolit123 neolit123 mentioned this pull request Dec 6, 2024
Open
@pacoxu
Copy link
Member

pacoxu commented Dec 16, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 63168f3 into kubernetes:master Dec 16, 2024
6 of 7 checks passed
@k8s-ci-robot
Copy link
Contributor

@HirazawaUi: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubeadm-instance-config.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-instance-config.yaml

In response to this:

Add e2e test for kubelet instance config.

relate: kubernetes/kubeadm#3126

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@dims dims Awaiting requested review from dims

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HirazawaUi @k8s-ci-robot @neolit123 @pacoxu