e2e_node: update userns job to run serially #33511
Conversation
at the time of writing, there's only a handful, and this opens the gate for more tests that must be run serially Signed-off-by: Peter Hunt <pehunt@redhat.com>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/node
|
/assign @kannon92 |
|
It looks like @haircommander is adding kubernetes/kubernetes#127484 so it is possible to test this serially. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@haircommander: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -1280,7 +1280,7 @@ presubmits: | |||
| - '--node-test-args=--service-feature-gates="UserNamespacesSupport=true,ProcMountType=true" --feature-gates="UserNamespacesSupport=true,ProcMountType=true" --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' | |||
| - --node-tests=true | |||
| - --provider=gce | |||
| - --test_args=--nodes=8 --focus="\[NodeFeature:ProcMountType\]" --skip="\[Flaky\]|\[Slow\]|\[Serial\]" | |||
| - --test_args=--nodes=1 --focus="\[NodeFeature:ProcMountType\]|\[NodeFeature:UserNamespacesSupport\]" | |||
There was a problem hiding this comment.
should we explicitly query for Serial tag here? It is not ideal to run non-serial tests (if there will be any) in the serial job
There was a problem hiding this comment.
according to https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/127484/pull-kubernetes-node-crio-cgrpv2-userns-e2e-serial/1836871735580823552 there's only 16 tests. maybe not ideal to have the only option to run the non serial jobs serially, but the impact is not that wide and I figured it'd be worth saving the complexity in the job definitions
There was a problem hiding this comment.
actually only 2 are non serial jobs. 3 are serial tests, and the remaining 11 are setup/teardown
There was a problem hiding this comment.
we need at least to add a comment about it. Whenever we have non-standard test description we need to clarify why they are non-standard
at the time of writing, there's only a handful, and this opens the gate for more tests that must be run serially