Adding a build-test-federation-e2e-gce job to pr builder job #335
Conversation
|
cc @kubernetes/test-infra-maintainers @ixdy |
| if [[ ${{rc}} -ne 0 ]]; then | ||
| if [[ -x cluster/log-dump.sh && -d _artifacts ]]; then | ||
| echo "Dumping logs for any remaining nodes" | ||
| ./cluster/log-dump.sh _artifacts |
There was a problem hiding this comment.
This I think will dump the logs from nodes from only one cluster
|
I am not sure how will users be able to access the logs, I assume a "Details" link will automatically appear in the list of checks, clicking on which will give the logs. |
| @@ -51,6 +51,7 @@ | |||
| - github-pull-request: | |||
| # This is the Jenkins GHPRB plugin ID, not the actual github token. | |||
| auth-id: 'f8e31bc1-9abb-460a-a2ca-9c4aae3ca4e8' | |||
| only-trigger-phrase: {only-trigger-phrase} | |||
There was a problem hiding this comment.
you might need to put this in single quotes.
you definitely will need to set only-trigger-phrase explicitly to false for all of the other builds.
There was a problem hiding this comment.
single quotes should not be required (I see other fields here without quotes, status-context for ex).
But this did not work, it resulted in <onlyTriggerPhrase>ordereddict([('only-trigger-phrase', none)])</onlyTriggerPhrase>. Will try adding quotes.
There was a problem hiding this comment.
Adding quotes fixed it.
|
@ixdy Can I get LGTM please :) |
| status-context: Federation GCE e2e | ||
| max-total: 12 | ||
| only-trigger-phrase: true # This test should run only if explicitly triggered. | ||
| trigger-phrase: 'federation+gce+e2e+test' |
There was a problem hiding this comment.
this phrase is a Java regex - you probably want \s+, not just +.
|
When we add a new job the plugin goes and tries to run it for every open PR which is a bit of a hassle, so we need to merge with care. |
| @@ -51,6 +52,7 @@ | |||
| - github-pull-request: | |||
| # This is the Jenkins GHPRB plugin ID, not the actual github token. | |||
| auth-id: 'f8e31bc1-9abb-460a-a2ca-9c4aae3ca4e8' | |||
| only-trigger-phrase: '{only-trigger-phrase}' | |||
There was a problem hiding this comment.
I think here you have to do the same trick we do for the disabled parameter, something like {obj:only-trigger-phrase}.
There was a problem hiding this comment.
Why do you think so?
I checked the diff this PR produced on travis and that seemed correct to me.
There was a problem hiding this comment.
If you ever set one to 'false' through a variable then it will actually be True because bool('false') is True.
|
Created a new project which should have the correct service accounts and permissions. |
|
@gmarek - we should reuse this experience and do exactly the same for kubemark |
|
@wojtek-t - we can try:) |
|
LGTM. I'm happy to merge this to see what's broken and iterate. |
ixdy
added
the
lgtm
|
Might want to email kubernetes-dev (or at least watch slack) to let folks know where the new commit status is coming from. |
|
The new commit status will only come if someone explicitly requests it by posting |
|
@kubernetes/test-infra-admins How do I get this PR merged? |
|
Yup, manual merges are the way to go in this repo. Based on @ixdy's LGTM above, I'm going to merge this now. |
ghost
merged commit 
…ements_schedule_throughput_fix2 ClusterLoader - Minor logging fix
Ref #155 kubernetes/kubernetes#26723
Have set only-trigger-phrase to true, so that it should only be triggered if explicitly requested via
@k8s-bot federation gce e2e test thiscc @kubernetes/sig-cluster-federation @colhom
The parameters for the job are copied from build-test-e2e-gce. Federation specific params are copied from
test-infra/jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e-gce.yaml
Line 220 in 9cc2592