Migrate jobs to use --test_args instead of GINKGO_TEST_ARGS and SKEW_KUBECTL #3309
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
The changes in |
experiment/test_config.yaml
Outdated
| autoscaling: | ||
| args: | ||
| - --timeout=300m | ||
| - --ginkgo.focus=\[Feature:ClusterSizeAutoscalingScaleUp\]|\[Feature:ClusterSizeAutoscalingScaleDown\] --ginkgo.skip=\[Flaky\] |
There was a problem hiding this comment.
wonder if one line is ok, or it need to be two flags --ginkgo.focus and --ginkgo.skip separately
There was a problem hiding this comment.
ah @yguo0905 you got better eyes :-)
| @@ -1,2 +1 @@ | |||
| GINKGO_TEST_ARGS=--ginkgo.skip=\[Slow\]|\[Serial\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\] | |||
| GINKGO_PARALLEL=y | |||
There was a problem hiding this comment.
the file only contains GINKGO_PARALLEL=y now.. maybe have a --parallel=true flag instead? thoughts?
There was a problem hiding this comment.
Yes, but can I do this in a separate PR?
This is deceptively complicated as this var is processed by ginkgo-e2e.sh, not e2e-runner.sh nor kubetest
There was a problem hiding this comment.
AKA this is not part of migrating e2e-runner.sh env to kubetest but the opposite (migrating ginkgo-e2e.sh stuff into kubetest)
There was a problem hiding this comment.
ack - maybe just move the env to their original env files... those suite/*.env files are not loved anymore 🔥
There was a problem hiding this comment.
Will do this in a separate PR (delete the suite/*.env files and migrate their configs to the job.env)
jobs/config.json
Outdated
| @@ -270,7 +281,8 @@ | |||
| "--extract=ci/latest-1.5", | |||
| "--extract=ci/latest-1.6", | |||
| "--check-leaked-resources", | |||
| "--check-version-skew=false" | |||
| "--check-version-skew=false", | |||
| "--test_args=None" | |||
There was a problem hiding this comment.
this one seems wrong, should be --ginkgo.focus=\[Feature:ClusterDowngrade\] --upgrade-target=ci/latest-1.5 --gce-upgrade-script=/workspace/kubernetes_skew/cluster/gce/upgrade.sh --etcd-upgrade-storage=etcd2 --etcd-upgrade-version=2.2.1
| problems.append('Cannot skew kubectl without tests %s' % job) | ||
| if tests: | ||
| problems.append('Cannot --test_args when --test=false %s' % job) | ||
| continue |
There was a problem hiding this comment.
maybe check if --test is true but --test_args is None here, that seems should not happen.
|
@yguo0905 any chance I can get an /lgtm? Sen is out the rest of this week |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ref #2829
/assign @yguo0905 @krzyzacy
Also fixed etcd upgrade and gke-large jobs that try to set
--test_argswhen--test=false