Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ProwJob ThirdPartyResource and clean up old ones. #2218

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Add ProwJob ThirdPartyResource and clean up old ones. #2218

merged 1 commit into from
Mar 30, 2017

Conversation

spxtr
Copy link
Contributor

@spxtr spxtr commented Mar 10, 2017 •
edited
Loading

This is step 1 of #2054.

@spxtr spxtr added the area/prow Issues or PRs related to prow label Mar 10, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 10, 2017
@spxtr spxtr mentioned this pull request Mar 11, 2017
Closed
7 tasks
@spxtr spxtr force-pushed the tpr branch 2 times, most recently from 2823677 to a4d8ced Compare March 13, 2017 20:25
@spxtr spxtr changed the title Add CIJob ThirdPartyResource and clean up old ones. Add ProwJob ThirdPartyResource and clean up old ones. Mar 13, 2017
@spxtr spxtr force-pushed the tpr branch 5 times, most recently from 49b2767 to 608bcc2 Compare March 13, 2017 23:28
@spxtr spxtr mentioned this pull request Mar 14, 2017
Merged
@spxtr
Copy link
Contributor Author

spxtr commented Mar 28, 2017

ping @rmmh

@rmmh
Copy link
Contributor

rmmh commented Mar 29, 2017

/lgtm

looks reasonable

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2017
@spxtr spxtr merged commit 8bc0201 into kubernetes:master Mar 30, 2017
@spxtr spxtr deleted the tpr branch March 30, 2017 17:34
@0xmichalis 0xmichalis mentioned this pull request Apr 2, 2017
Closed
@foxish
Copy link
Contributor

foxish commented Apr 7, 2017

@spxtr One of the things to add here might be an OwnerReference. It can help ensure that the TPR and the Pod acting as the controller are always cleaned up together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rmmh rmmh

Labels
area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spxtr @rmmh @foxish @k8s-ci-robot