Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cluster-api-aws to image promoter configs #13402

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Add cluster-api-aws to image promoter configs #13402

merged 1 commit into from
Jul 11, 2019

Conversation

detiber
Copy link
Member

@detiber detiber commented Jul 11, 2019

Adds the cluster-api-aws staging repo to the image promoter configs

/assign @dims
/cc @spiffxp @amy @listx

Related to kubernetes/k8s.io#300

@k8s-ci-robot k8s-ci-robot requested review from amy, listx and spiffxp July 11, 2019 15:54
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2019
@spiffxp
Copy link
Member

spiffxp commented Jul 11, 2019

/approve
/lgtm
/hold
pending merge of kubernetes/k8s.io#308

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d26806eda9e3dc1394bfb1b8761eb362e1db89ff

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2019
@detiber
Copy link
Member Author

detiber commented Jul 11, 2019

@spiffxp this shouldn't be blocked on kubernetes/k8s.io#308, that one is related to the k8s-staging-cluster-api repo, and this is to enable the promotion process for the k8s-staging-cluster-api-aws repo.

@dims
Copy link
Member

dims commented Jul 11, 2019

/hold cancel

per last comment from @detiber

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3470de4 into kubernetes:master Jul 11, 2019
@k8s-ci-robot
Copy link
Contributor

@detiber: Updated the job-config configmap in namespace default using the following files:

  • key container-image-promoter.yaml using file config/jobs/kubernetes/sig-release/cip/container-image-promoter.yaml
  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

Adds the cluster-api-aws staging repo to the image promoter configs

/assign @dims
/cc @spiffxp @amy @listx

Related to kubernetes/k8s.io#300

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy amy Awaiting requested review from amy

@listx listx Awaiting requested review from listx

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@dims dims

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@detiber @spiffxp @k8s-ci-robot @dims