Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

triage - upgrade py2 -> py3, #13164 #13380

Merged
merged 1 commit into from
Aug 5, 2019
Merged

triage - upgrade py2 -> py3, #13164 #13380

merged 1 commit into from
Aug 5, 2019

Conversation

clarketm
Copy link
Contributor

This is the successor to #13368 regarding the python2 -> python3 ( #13164 ) migration and targets the triage directory. Sorry for the significant diff. A majority of the changes pertain to increased indentation as a result of closing up potential resource leaks w/ open(); without this change, the tests were failing when executed with the pypy3 python interpreter.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @clarketm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from fejta and Katharine July 10, 2019 00:25
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/triage sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 10, 2019
@clarketm clarketm mentioned this pull request Jul 10, 2019
Merged
@chases2
Copy link
Contributor

chases2 commented Jul 10, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2019
@clarketm clarketm force-pushed the triage branch 2 times, most recently from a4bd922 to 933e847 Compare July 10, 2019 22:59
fejta
fejta approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

hack/verify-pylint.sh Show resolved Hide resolved
triage/summarize.py Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 11, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 57413bd714dba2975ce3a847b9cbfd4fb7db3626

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2019
fejta
fejta approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@clarketm
Copy link
Contributor Author

The associated issue for the support needed to dynamically select python version/interpreter: bazelbuild/rules_python#178

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1077c3e16125977df620049d5555332c52ef0f38

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2019
@fejta fejta mentioned this pull request Aug 1, 2019
Closed
17 tasks
@clarketm clarketm mentioned this pull request Aug 1, 2019
Merged
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 2, 2019
@clarketm
Copy link
Contributor Author

clarketm commented Aug 2, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3253bb07f69cd55eebba4cae9d66eb4858a10c52

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clarketm, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9a1e176 into kubernetes:master Aug 5, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 5, 2019
@clarketm clarketm deleted the triage branch August 24, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta approved these changes

@Katharine Katharine Awaiting requested review from Katharine

Assignees

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/triage cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
4 participants
@clarketm @k8s-ci-robot @chases2 @fejta