ghproxy: add instructions on how to use #10538

nikhita · 2018-12-21T13:26:41Z

I think the wording can definitely be improved. Suggestions welcome.

k8s-ci-robot · 2018-12-21T13:27:10Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nikhita
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cjwagner

If they are not already assigned, you can assign the PR to them by writing /assign @cjwagner in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

ghproxy/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alvaroaleman · 2018-12-21T13:29:09Z

ghproxy/README.md

+To use ghProxy for your prow instance,
+
+- Create a `StorageClass` using [`gce-ssd-retain_storageclass.yaml`](/prow/cluster/gce-ssd-retain_storageclass.yaml)


What is the benefit of the storageclass here?

It's used in the PVC mentioned below.

Okay sorry, let me rephrase my question: What is the advantage of using a Storageclass with reclaimPolicy: Retain here?

If you redeploy ghproxy and you end up reclaiming the data by a new deployment, we want the data to not have been deleted.

Doesn't that require manual intervention to produce that effect? If the PVC was deleted, at least the PersistentVolume.Spec.ClaimRef.UID field needs to be cleared to make it's available again to be bound to the same claim.

AFAIK, reclaimPolicy: retain only means that the PV is not deleted when the PVC is deleted. If the PVC is recreated then a new PV is provisioned (and a new persistent desk on GCP). If the PVC is not deleted and only the deployment is recreated, then the PVC should be bound to the same PV regardless of the reclaimPolicy set.

Interesting. My understanding of PV binding is definitely shakey. @cjwagner thoughts?

Yeah that makes a lot of sense. I guess we could remove that and just keep the storage class for the SSD type?

alvaroaleman · 2018-12-21T13:30:13Z

ghproxy/README.md

+[here](https://github.com/kubernetes/test-infra/blob/6cd6c2332d493b4d141822cbaa3ffe5806f64825/prow/cluster/hook_deployment.yaml#L43).
+To make sure that the client is able to bypass cache if it is temporarily unavailable,
+you can additionally use `--github-endpoint=https://api.github.com`. The endpoints are used in the order


What about [...] in the order they are mentioned, the first endpoint that does not return a connection error will be used?

stevekuznetsov · 2018-12-21T17:43:42Z

ghproxy/README.md

+To use ghProxy for your prow instance,
+
+- Create a `StorageClass` using [`gce-ssd-retain_storageclass.yaml`](/prow/cluster/gce-ssd-retain_storageclass.yaml)


If you redeploy ghproxy and you end up reclaiming the data by a new deployment, we want the data to not have been deleted.

stevekuznetsov · 2018-12-21T17:44:36Z

ghproxy/README.md

+## How to use
+
+To use ghProxy for your prow instance,


Instead of words here, why not

kubectl apply -f prow/cluster/gce-ssd-retain_storageclass.yaml kubectl apply -f prow/cluster/ghproxy_deployment.yaml kuebctl apply -f prow/cluster/ghproxy_service.yaml

stevekuznetsov · 2018-12-21T17:45:02Z

ghproxy/README.md

+- Create a `PersistentVolumeClaim` and `Deployment` using the config [here](prow/cluster/ghproxy_deployment.yaml).
+- Finally, create a [`Service`](/prow/cluster/ghproxy_service.yaml).
+- In the deployments for your prow components, use `--github-endpoint=http://ghproxy` as shown


This depends on the service name but should be fine to have this value here

stevekuznetsov · 2018-12-21T17:45:41Z

ghproxy/README.md

+[here](https://github.com/kubernetes/test-infra/blob/6cd6c2332d493b4d141822cbaa3ffe5806f64825/prow/cluster/hook_deployment.yaml#L43).
+To make sure that the client is able to bypass cache if it is temporarily unavailable,
+you can additionally use `--github-endpoint=https://api.github.com`. The endpoints are used in the order


Instead of "additionally use" maybe "also add the --github-... flag" or something

cjwagner · 2018-12-21T19:11:10Z

ghproxy/README.md

+- Create a `StorageClass` using [`gce-ssd-retain_storageclass.yaml`](/prow/cluster/gce-ssd-retain_storageclass.yaml)
+if on GCE or specify your own storage class.
+- Create a `PersistentVolumeClaim` and `Deployment` using the config [here](prow/cluster/ghproxy_deployment.yaml).


Bad link

Suggested change

- Create a `PersistentVolumeClaim` and `Deployment` using the config [here](prow/cluster/ghproxy_deployment.yaml).

- Create a `PersistentVolumeClaim` and `Deployment` using the config [here](/prow/cluster/ghproxy_deployment.yaml).

cjwagner · 2018-12-21T19:14:22Z

ghproxy/README.md

+- Create a `PersistentVolumeClaim` and `Deployment` using the config [here](prow/cluster/ghproxy_deployment.yaml).
+- Finally, create a [`Service`](/prow/cluster/ghproxy_service.yaml).
+- In the deployments for your prow components, use `--github-endpoint=http://ghproxy` as shown


We should explicitly mention that this should be done for all prow components that use the main Prow bot token. (i.e. deployments that use the oauth-token secret).

ixdy · 2019-01-30T18:47:59Z

/uncc

fejta · 2019-03-26T06:34:54Z

This sounds cool. Any chance you'll get back to it?

k8s-ci-robot · 2019-04-30T19:03:12Z

@nikhita: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-test-infra-lint	`441375b`	link	`/test pull-test-infra-lint`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fejta-bot · 2019-08-01T16:30:04Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2019-08-31T17:30:19Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · 2019-09-30T18:14:07Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2019-09-30T18:14:15Z

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ghproxy: add instructions on how to use

441375b

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/ghproxy Issues or PRs related to code in /ghproxy labels Dec 21, 2018

k8s-ci-robot requested review from cjwagner and ixdy December 21, 2018 13:27

alvaroaleman reviewed Dec 21, 2018

View reviewed changes

stevekuznetsov reviewed Dec 21, 2018

View reviewed changes

cjwagner reviewed Dec 21, 2018

View reviewed changes

ibrasho mentioned this pull request Jan 14, 2019

REQUEST: New membership for @ibrasho kubernetes/org#352

Closed

6 tasks

k8s-ci-robot removed the request for review from ixdy January 30, 2019 18:47

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 1, 2019

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 31, 2019

k8s-ci-robot closed this Sep 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ghproxy: add instructions on how to use #10538

ghproxy: add instructions on how to use #10538

nikhita commented Dec 21, 2018

k8s-ci-robot commented Dec 21, 2018

alvaroaleman Dec 21, 2018

ibrasho Dec 21, 2018 •

edited

Loading

alvaroaleman Dec 21, 2018

stevekuznetsov Dec 21, 2018

ibrasho Dec 21, 2018 •

edited

Loading

stevekuznetsov Dec 21, 2018

cjwagner Dec 21, 2018

alvaroaleman Dec 21, 2018

stevekuznetsov Dec 21, 2018

stevekuznetsov Dec 21, 2018

stevekuznetsov Dec 21, 2018

stevekuznetsov Dec 21, 2018

cjwagner Dec 21, 2018

cjwagner Dec 21, 2018

ixdy commented Jan 30, 2019

fejta commented Mar 26, 2019

k8s-ci-robot commented Apr 30, 2019 •

edited

Loading

fejta-bot commented Aug 1, 2019

fejta-bot commented Aug 31, 2019

fejta-bot commented Sep 30, 2019

k8s-ci-robot commented Sep 30, 2019

		To use ghProxy for your prow instance,

		- Create a `StorageClass` using [`gce-ssd-retain_storageclass.yaml`](/prow/cluster/gce-ssd-retain_storageclass.yaml)

	- Create a `PersistentVolumeClaim` and `Deployment` using the config [here](prow/cluster/ghproxy_deployment.yaml).
	- Create a `PersistentVolumeClaim` and `Deployment` using the config [here](/prow/cluster/ghproxy_deployment.yaml).

ghproxy: add instructions on how to use #10538

ghproxy: add instructions on how to use #10538

Conversation

nikhita commented Dec 21, 2018

k8s-ci-robot commented Dec 21, 2018

Choose a reason for hiding this comment

ibrasho Dec 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ibrasho Dec 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ixdy commented Jan 30, 2019

fejta commented Mar 26, 2019

k8s-ci-robot commented Apr 30, 2019 • edited Loading

fejta-bot commented Aug 1, 2019

fejta-bot commented Aug 31, 2019

fejta-bot commented Sep 30, 2019

k8s-ci-robot commented Sep 30, 2019

ibrasho Dec 21, 2018 •

edited

Loading

ibrasho Dec 21, 2018 •

edited

Loading

k8s-ci-robot commented Apr 30, 2019 •

edited

Loading