Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prow/config/secret: extract SecretAgent to a separate package #10482

Merged
merged 1 commit into from
Dec 20, 2018
Merged

prow/config/secret: extract SecretAgent to a separate package #10482

merged 1 commit into from
Dec 20, 2018

Conversation

ibrasho
Copy link
Contributor

@ibrasho ibrasho commented Dec 19, 2018

As per @fejta request, this PR extracts SecretAgent from prow/config into a new prow/config/secret package.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @ibrasho. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2018
@k8s-ci-robot k8s-ci-robot added area/label_sync Issues or PRs related to code in /label_sync area/prow Issues or PRs related to prow area/prow/branchprotector Issues or PRs related to prow's branchprotector component area/prow/hook Issues or PRs related to prow's hook component area/prow/jenkins-operator Issues or PRs related to prow's jenkins-operator component area/prow/peribolos Issues or PRs related to prow's peribolos component area/prow/plank Issues or PRs related to prow's plank component area/prow/tide Issues or PRs related to prow's tide component labels Dec 19, 2018
@ibrasho
Copy link
Contributor Author

ibrasho commented Dec 19, 2018

Also, LoadSecrets and LoadSingleSecret were moved to the new package.

@fejta
Copy link
Contributor

fejta commented Dec 19, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 19, 2018
@fejta
Copy link
Contributor

fejta commented Dec 19, 2018

/assign

@ibrasho ibrasho force-pushed the extract-secret-agent branch 2 times, most recently from b3d7f1a to 9527a76 Compare December 19, 2018 08:35
@stevekuznetsov
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa46cede096ac0bc00c1be94298efa844427cbbb

fejta
fejta approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Feel free to accept some my requested changes or reject them and leave a /hold cancel

prow/cmd/peribolos/main.go
@@ -23,15 +23,16 @@ import (
"os"
"strings"

"github.com/sirupsen/logrus"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What tool is doing this (moving this import section?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a file watcher that runs goimports on save. Also, a habit of organizing import in stdlib, external, internal groups. I think I moved this one manually.

prow/cmd/tackle/main.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, ibrasho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2018
@ibrasho
prow/config/secret: extract SecretAgent to a separate package
205be8c 
Signed-off-by: Ibrahim AshShohail <me@ibrasho.com>
@ibrasho ibrasho force-pushed the extract-secret-agent branch from 9527a76 to 205be8c Compare December 20, 2018 00:01
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2018
@fejta
Copy link
Contributor

fejta commented Dec 20, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 629f161d082a878c378f3d6adcc80aa837e637ff

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2018
fejta
fejta reviewed Dec 20, 2018
View reviewed changes
prow/cmd/status-reconciler/main.go
@@ -26,6 +26,7 @@ import (

"k8s.io/test-infra/pkg/flagutil"
"k8s.io/test-infra/prow/config"
"k8s.io/test-infra/prow/config/secret"
prowflagutil "k8s.io/test-infra/prow/flagutil"
_ "k8s.io/test-infra/prow/hook"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjwagner @stevekuznetsov any idea why we need this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we need to import all plugins to actually load the plugin config. If you don't import the plugins we fail validation on plugin config loading as we don't find the plugin names registered.

@stevekuznetsov
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit ace81c4 into kubernetes:master Dec 20, 2018
@ibrasho ibrasho mentioned this pull request Jan 14, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@fejta fejta fejta approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@cjwagner cjwagner Awaiting requested review from cjwagner

Assignees

@fejta fejta

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync area/prow/branchprotector Issues or PRs related to prow's branchprotector component area/prow/hook Issues or PRs related to prow's hook component area/prow/jenkins-operator Issues or PRs related to prow's jenkins-operator component area/prow/peribolos Issues or PRs related to prow's peribolos component area/prow/plank Issues or PRs related to prow's plank component area/prow/tide Issues or PRs related to prow's tide component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ibrasho @k8s-ci-robot @fejta @stevekuznetsov