Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run kubernetes-e2e-gce-federation as part of tests that merge bot runs on each PR #155

Closed
nikhiljindal opened this issue Jun 14, 2016 · 7 comments
Assignees

Comments

@nikhiljindal
Copy link
Contributor

This is to catch PRs that break federation tests.

cc @kubernetes/sig-testing @ixdy @kubernetes/sig-cluster-federation

@nikhiljindal
Copy link
Contributor Author

Ref kubernetes/kubernetes#26723

@nikhiljindal
Copy link
Contributor Author

This is blocking kubernetes-retired/contrib#1198.

@kubernetes/sig-testing who can help while @ixdy is out?

@ghost ghost assigned fejta Jul 19, 2016
@ghost ghost added the priority/P1 label Jul 19, 2016
@spxtr
Copy link
Contributor

spxtr commented Jul 19, 2016

You'll need to make a PR adding a new entry to this yaml file.

It looks like the federation tests take ~40 minutes to run on post-submit Jenkins. You'll have to cut out tests to get build + test time down to 30 minutes or so.

@nikhiljindal
Copy link
Contributor Author

Is it possible to run federation-e2e suite only if there is a change in federation/ directory?
That way only federation related PRs will be affected by the longer test running time, which might be acceptable?

@madhusudancs
Copy link
Contributor

The trouble with watching for changes only in federation directory is, all our code is not in that directory. We use a ton of code from the packages outside and a change there could break us badly. See - kubernetes/kubernetes#29123 for example.

But having said that, having something that works is better than nothing. If it is easier to just watch for changes in the federation directory I think that should be a good start, but it is not worth building out the infrastructure for that if it doesn't exist already.

@nikhiljindal
Copy link
Contributor Author

Agreed. Its better to have federation e2e tests running at least on PRs that change code in federation/ dir, while we figure out how to reduce the run time of our test suite.

@nikhiljindal
Copy link
Contributor Author

Have sent #335 so that anyone can type @k8s-bot federation gce e2e test this on any PR which will trigger federation tests with code in that PR.

That should help decrease some pain

@fejta fejta closed this as completed Aug 20, 2016
simonswine pushed a commit to simonswine/test-infra that referenced this issue Mar 23, 2018
Switch to lifecycle plugin from close
mborsz pushed a commit to mborsz/test-infra that referenced this issue Dec 14, 2018
ostromart pushed a commit to ostromart/test-infra that referenced this issue Jul 26, 2019
* Create a new branch for fast forward
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants